search

iTwin / itwinjs-core

Monorepo for iTwin.js Library
https://www.itwinjs.org
MIT License
615 stars 210 forks source link

Setting the background base map to a any color gives a white background #3292

Closed mdastous-bentley closed 2 years ago

mdastous-bentley commented 2 years ago

Describe the bug Using maplayers widget, switching from Bing maps to any solid color, gives a white background.

To Reproduce Steps to reproduce the behavior:

  1. Open ui-test-app with any imodel/bim.
  2. Open map-layers widget (might me collapsed on the right side)
  3. In the 'base' combo box, pick 'Solid Fill Color':

Expected behavior Background color of the map should match the one shown by the color picker.

Screenshots image

Desktop (please complete the applicable information):

pmconne commented 2 years ago

Easier repro steps:

  1. Open any geolocated iModel in display-test-app.
  2. Ensure the background map is enabled.
  3. Key in fdt set map base color 255 0 0

Expect: the background should be red. Observe: the view's own background color displays instead (not necessarily white).

pmconne commented 2 years ago

This regression was introduced by @RBBentley's #2881 for model map layers. I'll try to figure out what changed, and make sure we have tests to cover this.