iTwin / itwinjs-core

Monorepo for iTwin.js Library
https://www.itwinjs.org
MIT License
583 stars 211 forks source link

Review `core-electron` and `core-mobile` dependency on `presentation-common` #5129

Closed grigasp closed 1 year ago

grigasp commented 1 year ago

At the moment both core-electron and core-mobile have a dependency on presentation-common, because they automatically register the PresentationRpcInterface. I think that should be reconsidered, because:

4.0 seems like a good time to make the change.

calebmshafer commented 1 year ago

I agree, we should be consistent with the way we handle this going forward and it should have minimal impact overall. Let's try to get this in this week for the 4.0 release.

We'll need to make sure to update the Mobile SDK (@tcobbs-bentley and @toddsouthenbentley) as well as the iTwin Viewer desktop app (@aruniverse @ben-polinsky).

tcobbs-bentley commented 1 year ago

@calebmshafer The SDK portion of iTwin Mobile SDK does not contain any backend code. The iTwin Mobile sample app does. So the sample app will need to update to register this RPC, which should be easy.