Closed grigasp closed 1 year ago
I agree, we should be consistent with the way we handle this going forward and it should have minimal impact overall. Let's try to get this in this week for the 4.0 release.
We'll need to make sure to update the Mobile SDK (@tcobbs-bentley and @toddsouthenbentley) as well as the iTwin Viewer desktop app (@aruniverse @ben-polinsky).
@calebmshafer The SDK portion of iTwin Mobile SDK does not contain any backend code. The iTwin Mobile sample app does. So the sample app will need to update to register this RPC, which should be easy.
At the moment both
core-electron
andcore-mobile
have a dependency onpresentation-common
, because they automatically register thePresentationRpcInterface
. I think that should be reconsidered, because:PresentationRpcInterface
is not registered in case of web RPC, so there might be confusion why some hosts do that automatically others don't. And the web RPC can't automatically registerPresentationRpcInterface
because of circular dependencies betweencore-backend
andpresentation-backend
.There may be applications that don't need a Presentation RPC, e.g. imodel-console. In that case we have those dependencies unnecessarily.
4.0 seems like a good time to make the change.