Integrate fonts into workspaces

iTwin / itwinjs-core

Monorepo for iTwin.js Library

https://www.itwinjs.org

MIT License

582 stars 210 forks source link

Integrate fonts into workspaces #6751

Open pmconne opened 1 month ago

pmconne commented 1 month ago

Is your feature request related to a problem? Please describe. We now have the ability to store fonts in workspace dbs but it is entirely unused and it is not integrated with the Workspace APIs.

Describe the solution you'd like

Add "font" as a new type of WorkspaceResource.
Populate the native font db list from the workspaces
Support per-iModel font dbs
Make the native font db list thread-safe
Define and document collation rules for font names
Deprecate FontMap
Create a public font workspace db containing all fonts delivered with MicroStation (similar to our public GCS workspace db).
Fix tile generator failing to use last resort default fonts when it fails to find a requested font.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

kabentley commented 1 month ago

Define and document collation rules for font names

I sure hope that @khanaffan finishes his PR to make COLLATE NOCASE mean all Latin-1 characters.

khanaffan commented 1 month ago

Define and document collation rules for font names

I sure hope that @khanaffan finishes his PR to make COLLATE NOCASE mean all Latin-1 characters.

Its finished & merged but not enabled by default. I am still waiting for iQacs results.

ColinKerr commented 1 month ago

Define and document collation rules for font names

I sure hope that @khanaffan finishes his PR to make COLLATE NOCASE mean all Latin-1 characters.

Its finished & merged but not enabled by default. I am still waiting for iQacs results.

Since @khanaffan's pr allow us to turn the Latin-1 behavior on and off we can consider making this configurable via a setting in be_Props. We could set it to true for all new iModels and leave old iModels as is. This avoids us having to waste effort adding support for updating older iModels and would let us turn it on more quickly where it actually matters (new iModels).

pmconne commented 1 month ago

Since @khanaffan's pr allow us to turn the Latin-1 behavior on and off we can consider making this configurable via a setting in be_Props. We could set it to true for all new iModels and leave old iModels as is. This avoids us having to waste effort adding support for updating older iModels and would let us turn it on more quickly where it actually matters (new iModels).

When it comes to fonts, they will stop being embedded in iModels and start being embedded in workspaces. If we want ICU collation for font names, then we should configure font workspace dbs to use ICU collation from the outset.