search

iTwin / itwinjs-core

Monorepo for iTwin.js Library
https://www.itwinjs.org
MIT License
582 stars 210 forks source link

IModelDb.saveSettingDictionary should require the schema lock. #6781

Open pmconne opened 1 month ago

pmconne commented 1 month ago 
          @kabentley shouldn't `saveSettingDictionary` try to obtain the schema (file) lock?

_Originally posted by @pmconne in https://github.com/iTwin/itwinjs-core/pull/6646#discussion_r1607193738_

pmconne commented 3 weeks ago

Same for deleteSettingDictionary. Conflicts will only occur if two users attempt to modify the same row (i.e., the same dictionary) in different ways. OTOH, changing the iModel's settings dictionaries should really be an admin-only task, and admins will presumably want every one else to pull in those changes as soon as they're made - acquiring the schema lock is one way to accomplish that.