iTwin / itwinjs-core

Monorepo for iTwin.js Library
https://www.itwinjs.org
MIT License
620 stars 210 forks source link

Display edges only on some elements using appearance #7168

Open FelixGirard opened 1 month ago

FelixGirard commented 1 month ago

Is your feature request related to a problem? Please describe. Using the edit tools, we are creating 2d shapes that are closed (the geometry is a Loop). We have some 3d elements in the background that makes it so we can't use wireframe render mode.

I couldn't find any way to override the appearance to only show the edge of these shapes. I can kind of make them transparent fill, but that's about it.

Describe the solution you'd like Would like the ability to say don't fill those shape and use the weight and color to draw the edges.

Additional context Please don't hesitate to ask for more questions, clarifications or reach out directly. Thanks!

pmconne commented 1 month ago

Using the edit tools, we are creating 2d shapes that are closed (the geometry is a Loop)

Are they decorations/dynamics, or persistent elements?

FelixGirard commented 1 month ago

Persisted elements

pmconne commented 1 month ago

What prevents you from creating a Path instead of a Loop?

FelixGirard commented 1 month ago

I can create a Path (that's what we have right now as a work around). But is has some problems for other tools (like trim / extend). @bbastings

bbastings commented 1 month ago

@FelixGirard What problems? For most tools I allowed physically closed paths to be treated the same as loops...trim should treat them exactly the same.

GoldenGlaurung commented 1 month ago

I think the Trim/Extend Tool works well with what we currently have. The Break Curve tool might have issues with what we are currently doing (Brien and I have talked about workarounds but I've been working on other issues recently and haven't gotten around to figuring that out yet).