iTwin / itwinjs-core

Monorepo for iTwin.js Library
https://www.itwinjs.org
MIT License
620 stars 210 forks source link

deprecated Parser.parseToQuantityValue() #7180

Closed franklbh closed 1 month ago

franklbh commented 1 month ago

Deprecating Parser.parseToQuantityValue(), which will be marked as deprecated in version 4.10. The existing method Parser.parseQuantityString() should be used as a replacement.

Reason for Deprecation: The method Parser.parseQuantityString() is more appropriate for handling quantity parsing and is already in use in multiple places, such as:

The method Parser.parseToQuantityValue() is used sparingly in:

Given that the system has already moved to using Parser.parseQuantityString() in most cases, removing Parser.parseToQuantityValue() is reasonable.

hl662 commented 1 month ago

Please explain why this method will be deprecated

hl662 commented 1 month ago

The replacement for the method you are deprecating already exists, it would not be something new introduced into 4.10. Do you instead mean Parser.parseToQuantityValue() method will be deprecated in 4.10? Please update your PR description to reflect this.

hl662 commented 1 month ago

Your PR CI build failed, you missed running rush extract-api. Refer to our root README.md on instructions for fixing it.

franklbh commented 1 month ago

whats up with all the white space changes?

I think the spaces were automatically added, now they're gone

aruniverse commented 1 month ago

whats up with all the white space changes?

I think the spaces were automatically added, now they're gone

please check again,

image

also, lets add a nextver.md update about the deprecation