iTwin / itwinjs-core

Monorepo for iTwin.js Library
https://www.itwinjs.org
MIT License
606 stars 210 forks source link

Allow context reality model visibility to be toggled on/off (backport #7170) [release/4.9.x] #7186

Closed mergify[bot] closed 5 days ago

mergify[bot] commented 5 days ago

Similarly to map-layers, we want to be a able to turn off the display of a context reality model, without having to go trough the detach / attach process over and over..

Also, it should be possible to persist this visibility flag part of the view serialization process so that a reality can be loaded again, but remains invisible.


This is an automatic backport of pull request #7170 done by Mergify.

mergify[bot] commented 5 days ago

Cherry-pick of 956dfb7023828f3f4c6c9cdaa7c5179fedc932ca has failed:

On branch mergify/bp/release/4.9.x/pr-7170
Your branch is up to date with 'origin/release/4.9.x'.

You are currently cherry-picking commit 956dfb7023.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
    modified:   common/api/core-common.api.md
    new file:   common/changes/@itwin/core-common/realityModelVisibility_2024-09-19-20-56.json
    new file:   common/changes/@itwin/core-frontend/realityModelVisibility_2024-09-19-20-56.json
    modified:   core/common/src/ContextRealityModel.ts
    modified:   core/common/src/test/ContextRealityModel.test.ts
    modified:   core/frontend/src/DisplayStyleState.ts
    modified:   core/frontend/src/Viewport.ts
    modified:   core/frontend/src/test/SpatialViewState.test.ts

Unmerged paths:
  (use "git add <file>..." to mark resolution)
    both modified:   docs/changehistory/NextVersion.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally