iTwin / itwinjs-core

Monorepo for iTwin.js Library
https://www.itwinjs.org
MIT License
620 stars 210 forks source link

Raise SheetViewState.computeFitView from internal #7222

Closed Ellord207 closed 1 month ago

Ellord207 commented 1 month ago

SheetViewState.computeFitView has the internal tag, and is the only override of ViewState.computeFitView with the internal tag. Can the method please be raised from internal, or help me understand why it is marked that way and the alternatives.

We are using it in our workflows when generating view definition of new Sheet models. It is particularly helpful when the Model is new and empty.

pmconne commented 1 month ago

At one point we thought it would make sense to mark overridden methods as @internal to keep them from cluttering the docs, since all the useful documentation is on the base class method. That was misguided. Please submit a PR.