search

iTwin / itwinjs-core

Monorepo for iTwin.js Library
https://www.itwinjs.org
MIT License
620 stars 210 forks source link

SheetViewState.computeFitRange removed internal tag #7226

Closed Ellord207 closed 1 month ago

Ellord207 commented 1 month ago

Removes internal tag from SheetViewState.computeFitRange.

Resolves issue #7222

pmconne commented 1 month ago

@nick4598 fyi still occurring. Please temporarily mark the test as skipped if a fix will be delayed.

  1) CloudSqlite
       should LogLevel.Trace set LogMask to ALL:
     AssertError: expected _logInfo to not have been called but was called twice
    _logInfo('CloudSqlite', '16:20:23.120 | container test1 enters DELETE state', undefined) at logInfo (/home/vsts/work/1/s/core/bentley/src/Logger.ts:287:14)
    _logInfo('CloudSqlite', '16:20:23.120 | container test1 leaves DELETE state', undefined) at logInfo (/home/vsts/work/1/s/core/bentley/src/Logger.ts:287:14)
      at Object.fail (/home/vsts/work/1/s/common/temp/node_modules/.pnpm/sinon@17.0.2/node_modules/sinon/lib/sinon/assert.js:60:27)
      at failAssertion (/home/vsts/work/1/s/common/temp/node_modules/.pnpm/sinon@17.0.2/node_modules/sinon/lib/sinon/assert.js:203:20)
      at Object.assert.<computed> [as notCalled] (/home/vsts/work/1/s/common/temp/node_modules/.pnpm/sinon@17.0.2/node_modules/sinon/lib/sinon/assert.js:232:17)
      at Context.<anonymous> (src/integration/CloudSqlite.test.ts:251:18)