iTwin / itwinjs-core

Monorepo for iTwin.js Library
https://www.itwinjs.org
MIT License
620 stars 210 forks source link

Fix async worker return type #7249

Closed pmconne closed 1 month ago

pmconne commented 1 month ago

Fixes #7248.

7088 enabled support for asynchronous implementations of individual worker operations, to prevent long-running operations from blocking subsequent requests. But, the types did not accurately capture these semantics, so you couldn't return { result: T, transfer: Transferable[] } from async implementations without the compiler complaining. It would expect you to return { result: Promise<T>, transfer: Transferable[] } instead.

Adjusted the types to fix this.

mdastous-bentley commented 1 month ago

@aruniverse I would like to get it backported to 4.9.x

aruniverse commented 1 month ago

@mergifyio backport release/4.9.x

mergify[bot] commented 1 month ago

backport release/4.9.x

✅ Backports have been created

* [#7250 Fix async worker return type (backport #7249) [release/4.9.x]](https://github.com/iTwin/itwinjs-core/pull/7250) has been created for branch `release/4.9.x`