search

iTwin / itwinjs-core

Monorepo for iTwin.js Library
https://www.itwinjs.org
MIT License
620 stars 210 forks source link

Make classIdsToClassNames explicit parameter independent of UseJsPropertyName #7264

Open khanaffan opened 1 month ago

khanaffan commented 1 month ago

Previous behavior

UseJsPropertyName also implicitly mean ClassIdToClassName was true. But if explicitly specified ClassIdToClassName: false we did not return classId(s) instead it will still return class names.

New behavior

UseJsPropertyName still default to ClassIdToClassName: true unless ClassIdToClassName: false is specified. If false was specified, then classId(s) are returned.

Instance query when use with option USE_JS_NAMES continue to return UseJsPropertyName: true, ClassIdToClassName: true.

@soham-bentley added new test for various permutations of ECSqlRowFormat, classIdToClassNames & abbrivateBlob.

imodel-native: https://github.com/iTwin/imodel-native/pull/883

mergify[bot] commented 4 weeks ago

This pull request is now in conflicts. Could you fix it @khanaffan? 🙏 To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

aruniverse commented 2 weeks ago

does this need to be in a 4.9 patch?