search

iTwin / itwinjs-core

Monorepo for iTwin.js Library
https://www.itwinjs.org
MIT License
620 stars 210 forks source link

deprecate PresentationRpcInterface #7319

Closed paulius-valiunas closed 1 week ago

paulius-valiunas commented 1 week ago

We are planning to deprecate RPC altogether in the future, and while we don't have a replacement just yet, we can at least encourage people to use various wrappers instead of calling RPC interfaces directly. This way the transition to new APIs will be less disruptive. Presentation is the only RPC interface where all the methods are public and not internal.

hl662 commented 1 week ago

Maybe add a section in NextVersion.md saying the interface is deprecated

hl662 commented 1 week ago

should the PresentationRpcInterface class itself also be marked as deprecated?

paulius-valiunas commented 1 week ago

should the PresentationRpcInterface class itself also be marked as deprecated?

people still need a way to register it in their frontend/backend, so I can't just deprecate it... we would need to provide an alternative registration path, but that would be a big refactor and I think it's fine to just keep things this way for now. Once we move all the existing APIs, we can then deprecate RPCManager and related classes, as well as the RPC interfaces themselves. But at that point, we will probably be close to 6.0 where we can actually remove all the deprecated methods, so there wouldn't be any actual code in the deprecated interfaces.

mergify[bot] commented 1 week ago

This pull request is now in conflicts. Could you fix it @paulius-valiunas? 🙏 To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

mergify[bot] commented 1 week ago

This pull request is now in conflicts. Could you fix it @paulius-valiunas? 🙏 To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

paulius-valiunas commented 1 week ago

@mergifyio backport release/4.10.x

paulius-valiunas commented 1 week ago

@mergifyio backport release/4.11.x

mergify[bot] commented 1 week ago

backport release/4.10.x

✅ Backports have been created

* [#7333 deprecate PresentationRpcInterface (backport #7319) [release/4.10.x]](https://github.com/iTwin/itwinjs-core/pull/7333) has been created for branch `release/4.10.x` but encountered conflicts
mergify[bot] commented 1 week ago

backport release/4.11.x

✅ Backports have been created

* [#7334 deprecate PresentationRpcInterface (backport #7319) [release/4.11.x]](https://github.com/iTwin/itwinjs-core/pull/7334) has been created for branch `release/4.11.x` but encountered conflicts