search

iTwin / presentation

Monorepo for iTwin.js Presentation Library
https://www.itwinjs.org/presentation/
MIT License
4 stars 0 forks source link

Unified-selection performance tests #557

Closed jasdom closed 6 months ago

jasdom commented 6 months ago

Closes 537.

changeset-bot[bot] commented 6 months ago

🦋 Changeset detected

Latest commit: 907b4f0541aba2366ba89f773d6f7d2447b6e64b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------------------ | ----- | | @itwin/unified-selection | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 6 months ago

Benchmark

Benchmark suite Current: 30ec707fbbf1e60ba80d1c81eaf305098a3040a8 Previous: 8c7858539cb8040c5cf197e76b4dab9a67eb6d4d Deviation Status
hilite 50k elements 2926.22 ms
hilite 50k elements (P95 of main thread blocks) 1998 ms
hilite 50k group elements 213.17 ms
hilite 50k group elements (P95 of main thread blocks) 79 ms
hilite 1k subjects 45845.23 ms
hilite 1k subjects (P95 of main thread blocks) 31 ms
hilite 50k subcategories 248.72 ms
hilite 50k subcategories (P95 of main thread blocks) 120 ms
hilite 50k functional 3D elements 27528.24 ms
hilite 50k functional 3D elements (P95 of main thread blocks) 2168 ms
hilite 50k functional 2D elements 7968.26 ms
hilite 50k functional 2D elements (P95 of main thread blocks) 2051 ms
compute selection for 50k elements 317.72 ms
compute selection for 50k elements (P95 of main thread blocks) 136 ms
compute parent selection for 50k elements 349.51 ms
compute parent selection for 50k elements (P95 of main thread blocks) 123 ms
compute top ancestor selection for 50k elements 567.18 ms
compute top ancestor selection for 50k elements (P95 of main thread blocks) 0 ms
compute category selection for 50k elements 98.84 ms
compute category selection for 50k elements (P95 of main thread blocks) 0 ms
compute model selection for 50k elements 79.38 ms
compute model selection for 50k elements (P95 of main thread blocks) 0 ms
compute functional selection for 50k 3D elements 417.67 ms
compute functional selection for 50k 3D elements (P95 of main thread blocks) 132 ms
compute parent functional selection for 50k 3D elements 448.99 ms
compute parent functional selection for 50k 3D elements (P95 of main thread blocks) 123 ms
compute top ancestor functional selection for 50k 3D elements 1159.04 ms
compute top ancestor functional selection for 50k 3D elements (P95 of main thread blocks) 0 ms
compute functional selection for 50k 2D elements 2997.62 ms
compute functional selection for 50k 2D elements (P95 of main thread blocks) 0 ms
compute parent functional selection for 50k 2D elements 3020.17 ms
compute parent functional selection for 50k 2D elements (P95 of main thread blocks) 0 ms
compute top ancestor functional selection for 50k 2D elements 3075.85 ms
compute top ancestor functional selection for 50k 2D elements (P95 of main thread blocks) 0 ms

This comment was automatically generated by workflow using github-action-benchmark.

jasdom commented 6 months ago

It's not clear to me why we only got 1 PR comment from the action. You made changes to hierarchies-related workflow and performance test files, so I'd expect 2 comments - one for hierarchies and one for unified selection. Can you check?

To leave separate comments, each benchmark needs to have a unique name property, otherwise, a single comment would be used and the results would override each other, however the comment is only left when there is a previous run to compare to, and since the benchmark names changed, no such benchmark is found, so no comment is left until the pull request is merged.

The comment you are seeing is the one left when benchmark names are not changed, so the results of the new tests would be visible while the changes are in-review.