search

iTwin / presentation

Monorepo for iTwin.js Presentation Library
https://www.itwinjs.org/presentation/
MIT License
4 stars 0 forks source link

`hierarchies`: Fix filter targets with hidden child filter targets #603

Closed grigasp closed 3 months ago

grigasp commented 3 months ago

Fixes https://github.com/iTwin/presentation/issues/602

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: d989802f6fa0a9230d38383c5eddfe4c2aca87ed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ------------------------------------- | ----- | | @itwin/presentation-hierarchies | Patch | | @itwin/presentation-hierarchies-react | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 3 months ago

Hierarchies benchmark

Benchmark suite Current: d989802f6fa0a9230d38383c5eddfe4c2aca87ed Previous: b245b8e992f7e9a0d0f3916b8d4e9c036e6a14f1 Deviation Status
flat 50k elements list 4168.56 ms 4125.79 ms 1.0366% 🚨
flat 50k elements list (P95 of main thread blocks) 69 ms 74 ms -6.7568% ✅
grouping by label 10179.39 ms 10217.6 ms -0.3740% ✅
grouping by label (P95 of main thread blocks) 57 ms 67 ms -14.9254% ✅
grouping by class 10291.54 ms 10372.2 ms -0.7777% ✅
grouping by class (P95 of main thread blocks) 46 ms 42 ms 9.5238% 🚨
grouping by property 10795.15 ms 10826.86 ms -0.2929% ✅
grouping by property (P95 of main thread blocks) 79 ms 49 ms 61.2245% 🚨
grouping by base class (10 classes) 7504.48 ms 7344.47 ms 2.1786% 🚨
grouping by base class (10 classes) (P95 of main thread blocks) 77 ms 74 ms 4.0541% 🚨
grouping by multiple attributes 27647.22 ms 27609.99 ms 0.1348% 🚨
grouping by multiple attributes (P95 of main thread blocks) 67 ms 68 ms -1.4706% ✅
hide if no children required to finalize root, w/o children 46344 ms 47585.01 ms -2.6080% ✅
hide if no children required to finalize root, w/o children (P95 of main thread blocks) 39 ms 42 ms -7.1429% ✅
hide if no children required to finalize root, w/ children 157.62 ms 153.88 ms 2.4305% 🚨
hide if no children required to finalize root, w/ children (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
models tree initial (Baytown) 56.66 ms 56.68 ms -0.0353% ✅
models tree initial (Baytown) (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
models tree full (Baytown) 7582.78 ms 7633.97 ms -0.6706% ✅
models tree full (Baytown) (P95 of main thread blocks) 84 ms 105 ms -20% ✅

This comment was automatically generated by workflow using github-action-benchmark.