iTwin / presentation

Monorepo for iTwin.js Presentation Library
https://www.itwinjs.org/presentation/
MIT License
4 stars 0 forks source link

hierarchies: Expose node filtering props #620

Closed Yato333 closed 3 months ago

Yato333 commented 3 months ago

These properties are already exposed in the resulting nodes but the type doesn't reflect it. Related to: https://github.com/iTwin/viewer-components-react/issues/868

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 4f845f27066adeb2c6ce7714193ae87fbe057deb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ------------------------------------- | ----- | | @itwin/presentation-hierarchies | Patch | | @itwin/presentation-hierarchies-react | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 3 months ago

Hierarchies benchmark

Benchmark suite Current: 4f845f27066adeb2c6ce7714193ae87fbe057deb Previous: 88d0abbdfbff407b3c62bbeaa8c93e677b87486b Deviation Status
flat 50k elements list 4065.6 ms 4062.29 ms 0.0815% 🚨
flat 50k elements list (P95 of main thread blocks) 73 ms 69 ms 5.7971% 🚨
grouping by label 10040.41 ms 10125.4 ms -0.8394% ✅
grouping by label (P95 of main thread blocks) 68 ms 70 ms -2.8571% ✅
grouping by class 10128.75 ms 10261.77 ms -1.2963% ✅
grouping by class (P95 of main thread blocks) 45 ms 41 ms 9.7561% 🚨
grouping by property 10611.27 ms 10885.99 ms -2.5236% ✅
grouping by property (P95 of main thread blocks) 49 ms 48 ms 2.0833% 🚨
grouping by base class (10 classes) 7196.21 ms 7492.25 ms -3.9513% ✅
grouping by base class (10 classes) (P95 of main thread blocks) 74 ms 80 ms -7.5000% ✅
grouping by multiple attributes 27157.4 ms 28078.62 ms -3.2809% ✅
grouping by multiple attributes (P95 of main thread blocks) 58 ms 69 ms -15.9420% ✅
hide if no children required to finalize root, w/o children 45549.69 ms 44762.49 ms 1.7586% 🚨
hide if no children required to finalize root, w/o children (P95 of main thread blocks) 37 ms 38 ms -2.6316% ✅
hide if no children required to finalize root, w/ children 158.09 ms 160.28 ms -1.3664% ✅
hide if no children required to finalize root, w/ children (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
models tree initial (Baytown) 39.96 ms 41.78 ms -4.3562% ✅
models tree initial (Baytown) (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
models tree full (Baytown) 7478.46 ms 7499.2 ms -0.2766% ✅
models tree full (Baytown) (P95 of main thread blocks) 89 ms 88 ms 1.1364% 🚨

This comment was automatically generated by workflow using github-action-benchmark.