search

iTwin / presentation

Monorepo for iTwin.js Presentation Library
https://www.itwinjs.org/presentation/
MIT License
4 stars 0 forks source link

Hierarchies: fix `preProcessNode` and `postProcessNode` losing `this` context #625

Closed jasdom closed 3 months ago

jasdom commented 3 months ago

Fixed preProcessNode and postProcessNode not retaining this context.

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: c631670f2f12aecae7ea61471b424cd6d0961a05

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ------------------------------------- | ----- | | @itwin/presentation-hierarchies | Patch | | @itwin/presentation-hierarchies-react | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 3 months ago

Hierarchies benchmark

Benchmark suite Current: c631670f2f12aecae7ea61471b424cd6d0961a05 Previous: 8611d149a837d105941f997fcf137a90f1ab0462 Deviation Status
flat 50k elements list 4053.04 ms 4083.86 ms -0.7547% ✅
flat 50k elements list (P95 of main thread blocks) 69 ms 74 ms -6.7568% ✅
grouping by label 9946.2 ms 10098.92 ms -1.5122% ✅
grouping by label (P95 of main thread blocks) 59 ms 65 ms -9.2308% ✅
grouping by class 10025.15 ms 10285.13 ms -2.5277% ✅
grouping by class (P95 of main thread blocks) 42 ms 46 ms -8.6957% ✅
grouping by property 10638.43 ms 10636.6 ms 0.0172% 🚨
grouping by property (P95 of main thread blocks) 79 ms 53 ms 49.0566% 🚨
grouping by base class (10 classes) 7248.97 ms 7314.05 ms -0.8898% ✅
grouping by base class (10 classes) (P95 of main thread blocks) 74 ms 80 ms -7.5000% ✅
grouping by multiple attributes 27201.52 ms 27277.93 ms -0.2801% ✅
grouping by multiple attributes (P95 of main thread blocks) 47 ms 52 ms -9.6154% ✅
hide if no children required to finalize root, w/o children 44161.23 ms 46110.26 ms -4.2269% ✅
hide if no children required to finalize root, w/o children (P95 of main thread blocks) 38 ms 38 ms 0% 🟰
hide if no children required to finalize root, w/ children 149.55 ms 162.71 ms -8.0880% ✅
hide if no children required to finalize root, w/ children (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
models tree initial (Baytown) 43.8 ms 38.78 ms 12.9448% 🚨
models tree initial (Baytown) (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
models tree full (Baytown) 7498.42 ms 7548.44 ms -0.6627% ✅
models tree full (Baytown) (P95 of main thread blocks) 85 ms 85 ms 0% 🟰

This comment was automatically generated by workflow using github-action-benchmark.