iTwin / presentation

Monorepo for iTwin.js Presentation Library
https://www.itwinjs.org/presentation/
MIT License
4 stars 0 forks source link

`shared`: Nested `ConcatenatedValue` support #628

Closed grigasp closed 3 months ago

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 313cce99212435266e4f651a0a7859686871ccbe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages | Name | Type | | ------------------------------------- | ----- | | @itwin/presentation-shared | Minor | | @itwin/presentation-core-interop | Patch | | @itwin/presentation-hierarchies-react | Patch | | @itwin/presentation-hierarchies | Patch | | @itwin/unified-selection | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 3 months ago

Unified selection benchmark

Benchmark suite Current: 313cce99212435266e4f651a0a7859686871ccbe Previous: bda5efff29313d6931dbe128db1f4c678f7217f8 Deviation Status
hilite 50k elements 1200.54 ms 1305.69 ms -8.0532% ✅
hilite 50k elements (P95 of main thread blocks) 39 ms 56 ms -30.3571% ✅
hilite 50k group elements 229.32 ms 245.99 ms -6.7767% ✅
hilite 50k group elements (P95 of main thread blocks) 31 ms 32 ms -3.1250% ✅
hilite 1k subjects 46724.42 ms 46528.72 ms 0.4206% 🚨
hilite 1k subjects (P95 of main thread blocks) 34 ms 36 ms -5.5556% ✅
hilite 50k subcategories 274.52 ms 285.15 ms -3.7279% ✅
hilite 50k subcategories (P95 of main thread blocks) 33 ms 33 ms 0% 🟰
hilite 50k functional 3D elements 25693 ms 25765.77 ms -0.2824% ✅
hilite 50k functional 3D elements (P95 of main thread blocks) 41 ms 40 ms 2.5000% 🚨
hilite 50k functional 2D elements 6030.11 ms 6273.64 ms -3.8818% ✅
hilite 50k functional 2D elements (P95 of main thread blocks) 31 ms 40 ms -22.5000% ✅
compute selection for 50k elements 302.78 ms 312.38 ms -3.0732% ✅
compute selection for 50k elements (P95 of main thread blocks) 31 ms 31 ms 0% 🟰
compute parent selection for 50k elements 338.27 ms 349.91 ms -3.3266% ✅
compute parent selection for 50k elements (P95 of main thread blocks) 31 ms 31 ms 0% 🟰
compute top ancestor selection for 50k elements 560.8 ms 587.02 ms -4.4666% ✅
compute top ancestor selection for 50k elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute category selection for 50k elements 91.88 ms 95.36 ms -3.6493% ✅
compute category selection for 50k elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute model selection for 50k elements 76.82 ms 87.58 ms -12.2859% ✅
compute model selection for 50k elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute functional selection for 50k 3D elements 391.31 ms 407.82 ms -4.0484% ✅
compute functional selection for 50k 3D elements (P95 of main thread blocks) 31 ms 31 ms 0% 🟰
compute parent functional selection for 50k 3D elements 440.8 ms 451.15 ms -2.2941% ✅
compute parent functional selection for 50k 3D elements (P95 of main thread blocks) 31 ms 31 ms 0% 🟰
compute top ancestor functional selection for 50k 3D elements 1145.83 ms 1247.03 ms -8.1153% ✅
compute top ancestor functional selection for 50k 3D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute functional selection for 50k 2D elements 2991.51 ms 3195.14 ms -6.3731% ✅
compute functional selection for 50k 2D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute parent functional selection for 50k 2D elements 3011.73 ms 3270.98 ms -7.9258% ✅
compute parent functional selection for 50k 2D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute top ancestor functional selection for 50k 2D elements 3085.99 ms 3278.91 ms -5.8837% ✅
compute top ancestor functional selection for 50k 2D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

github-actions[bot] commented 3 months ago

Hierarchies benchmark

Benchmark suite Current: 313cce99212435266e4f651a0a7859686871ccbe Previous: 8715111b84824c617b25669f063cf22de40e5756 Deviation Status
flat 50k elements list 4107.47 ms 4150.06 ms -1.0263% ✅
flat 50k elements list (P95 of main thread blocks) 75 ms 73 ms 2.7397% 🚨
grouping by label 10078.53 ms 10259.25 ms -1.7615% ✅
grouping by label (P95 of main thread blocks) 61 ms 73 ms -16.4384% ✅
grouping by class 10135.6 ms 10459.6 ms -3.0976% ✅
grouping by class (P95 of main thread blocks) 41 ms 43 ms -4.6512% ✅
grouping by property 10653.56 ms 11079.23 ms -3.8421% ✅
grouping by property (P95 of main thread blocks) 80 ms 54 ms 48.1481% 🚨
grouping by base class (10 classes) 7252.14 ms 7681.68 ms -5.5917% ✅
grouping by base class (10 classes) (P95 of main thread blocks) 74 ms 84 ms -11.9048% ✅
grouping by multiple attributes 27317.43 ms 28063.5 ms -2.6585% ✅
grouping by multiple attributes (P95 of main thread blocks) 48 ms 46 ms 4.3478% 🚨
hide if no children required to finalize root, w/o children 46275.11 ms 48241.27 ms -4.0757% ✅
hide if no children required to finalize root, w/o children (P95 of main thread blocks) 41 ms 39 ms 5.1282% 🚨
hide if no children required to finalize root, w/ children 154.88 ms 174.57 ms -11.2791% ✅
hide if no children required to finalize root, w/ children (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
models tree initial (Baytown) 38.57 ms 42.15 ms -8.4935% ✅
models tree initial (Baytown) (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
models tree full (Baytown) 7546.11 ms 7800.46 ms -3.2607% ✅
models tree full (Baytown) (P95 of main thread blocks) 89 ms 90 ms -1.1111% ✅

This comment was automatically generated by workflow using github-action-benchmark.