search

iTwin / presentation

Monorepo for iTwin.js Presentation Library
https://www.itwinjs.org/presentation/
MIT License
4 stars 0 forks source link

Hierarchies: Fix like operator not matching substrings #634

Closed jasdom closed 2 months ago

jasdom commented 2 months ago

Fixes needed for https://github.com/iTwin/viewer-components-react/issues/903.

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: 1a8c7ed6d2d2adc8b3cf9208e6ae41a412fdc35e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ------------------------------------- | ----- | | @itwin/presentation-hierarchies | Patch | | @itwin/presentation-hierarchies-react | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 2 months ago

Hierarchies benchmark

Benchmark suite Current: 1a8c7ed6d2d2adc8b3cf9208e6ae41a412fdc35e Previous: b3d4b8146d354dfa61d108183ebd5f520f14f10f Deviation Status
flat 50k elements list 4094.25 ms 4166.74 ms -1.7397% ✅
flat 50k elements list (P95 of main thread blocks) 73 ms 74 ms -1.3514% ✅
grouping by label 10269.38 ms 10165.4 ms 1.0229% 🚨
grouping by label (P95 of main thread blocks) 61 ms 61 ms 0% 🟰
grouping by class 10403.84 ms 10233.31 ms 1.6664% 🚨
grouping by class (P95 of main thread blocks) 45 ms 44 ms 2.2727% 🚨
grouping by property 10821.58 ms 10904.37 ms -0.7592% ✅
grouping by property (P95 of main thread blocks) 54 ms 62 ms -12.9032% ✅
grouping by base class (10 classes) 7448.63 ms 7315.02 ms 1.8265% 🚨
grouping by base class (10 classes) (P95 of main thread blocks) 74 ms 78 ms -5.1282% ✅
grouping by multiple attributes 27646.66 ms 27148.16 ms 1.8362% 🚨
grouping by multiple attributes (P95 of main thread blocks) 70 ms 50 ms 40% 🚨
hide if no children required to finalize root, w/o children 46505.52 ms 45504.11 ms 2.2007% 🚨
hide if no children required to finalize root, w/o children (P95 of main thread blocks) 37 ms 38 ms -2.6316% ✅
hide if no children required to finalize root, w/ children 161.66 ms 164.28 ms -1.5948% ✅
hide if no children required to finalize root, w/ children (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
models tree initial (Baytown) 40.74 ms 39 ms 4.4615% 🚨
models tree initial (Baytown) (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
models tree full (Baytown) 7564.44 ms 7546.99 ms 0.2312% 🚨
models tree full (Baytown) (P95 of main thread blocks) 90 ms 90 ms 0% 🟰

This comment was automatically generated by workflow using github-action-benchmark.

jasdom commented 2 months ago

I'd argue that this PR doesn't close iTwin/viewer-components-react#903. It'll be closed when this fix is released and tree-widget consumes the fixed package :)

I guess you are right, updated the description