search

iTwin / presentation

Monorepo for iTwin.js Presentation Library
https://www.itwinjs.org/presentation/
MIT License
4 stars 0 forks source link

`hierarchies`: Add `onlyIfNotHandled` flag to class based hierarchy definitions #642

Closed Yato333 closed 2 months ago

Yato333 commented 2 months ago

Closes #596

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: 647d37db7e28b08b5aaca32f98dd55b47fdcbabc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ------------------------------------- | ----- | | @itwin/presentation-hierarchies | Minor | | @itwin/presentation-hierarchies-react | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 2 months ago

Hierarchies benchmark

Benchmark suite Current: 647d37db7e28b08b5aaca32f98dd55b47fdcbabc Previous: 10271007c204f27a4137d4b06a8285f3a5f52e72 Deviation Status
flat 50k elements list 4098.64 ms 4113.93 ms -0.3717% ✅
flat 50k elements list (P95 of main thread blocks) 72 ms 75 ms -4% ✅
grouping by label 9858.36 ms 9921.13 ms -0.6327% ✅
grouping by label (P95 of main thread blocks) 69 ms 60 ms 15% 🚨
grouping by class 9869.48 ms 9983.8 ms -1.1451% ✅
grouping by class (P95 of main thread blocks) 42 ms 42 ms 0% 🟰
grouping by property 10386.33 ms 10474.38 ms -0.8406% ✅
grouping by property (P95 of main thread blocks) 78 ms 84 ms -7.1429% ✅
grouping by base class (10 classes) 7128.06 ms 7237.86 ms -1.5170% ✅
grouping by base class (10 classes) (P95 of main thread blocks) 76 ms 77 ms -1.2987% ✅
grouping by multiple attributes 26720.3 ms 26842.54 ms -0.4554% ✅
grouping by multiple attributes (P95 of main thread blocks) 48 ms 71 ms -32.3944% ✅
hide if no children required to finalize root, w/o children 44125.26 ms 44437.45 ms -0.7025% ✅
hide if no children required to finalize root, w/o children (P95 of main thread blocks) 38 ms 38 ms 0% 🟰
hide if no children required to finalize root, w/ children 151.64 ms 154.82 ms -2.0540% ✅
hide if no children required to finalize root, w/ children (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
models tree initial (Baytown) 35.88 ms 38.42 ms -6.6111% ✅
models tree initial (Baytown) (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
models tree full (Baytown) 7509.95 ms 7554.49 ms -0.5896% ✅
models tree full (Baytown) (P95 of main thread blocks) 92 ms 93 ms -1.0753% ✅

This comment was automatically generated by workflow using github-action-benchmark.