iTwin / presentation

Monorepo for iTwin.js Presentation Library
https://www.itwinjs.org/presentation/
MIT License
4 stars 0 forks source link

Remove exposed internal APIs #655

Closed Yato333 closed 2 months ago

Yato333 commented 2 months ago

Closes #652 Unexported internal APIs that are used in exported ones (e.g. as parameters) will now have the release tag that matches the exported one. APIs that were exposed for testing purposes were hidden using Contexts except for FavoritePropertiesDataProvider where there can be utilized a private member assignment hack.

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: 9e90ae7e0b6e3d0d711dad7923a09513f7a0e5fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages | Name | Type | | ------------------------------------- | ----- | | @itwin/presentation-components | Patch | | @itwin/presentation-hierarchies-react | Patch | | @itwin/unified-selection | Patch | | @itwin/presentation-shared | Patch | | @itwin/presentation-testing | Patch | | @itwin/presentation-core-interop | Patch | | @itwin/presentation-hierarchies | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 2 months ago

Unified selection benchmark

Benchmark suite Current: 9e90ae7e0b6e3d0d711dad7923a09513f7a0e5fa Previous: 913e0305841ac0be650b5b7db06df68297a2bedc Deviation Status
hilite 50k elements 1246.11 ms 1201.7 ms 3.6956% 🚨
hilite 50k elements (P95 of main thread blocks) 46 ms 47 ms -2.1277% ✅
hilite 50k group elements 240.38 ms 231.28 ms 3.9346% 🚨
hilite 50k group elements (P95 of main thread blocks) 31 ms 31 ms 0% 🟰
hilite 1k subjects 48841.1 ms 47432.5 ms 2.9697% 🚨
hilite 1k subjects (P95 of main thread blocks) 27 ms 30 ms -10% ✅
hilite 50k subcategories 281.08 ms 271.04 ms 3.7043% 🚨
hilite 50k subcategories (P95 of main thread blocks) 34 ms 32 ms 6.2500% 🚨
hilite 50k functional 3D elements 25531.45 ms 25815.45 ms -1.1001% ✅
hilite 50k functional 3D elements (P95 of main thread blocks) 40 ms 36 ms 11.1111% 🚨
hilite 50k functional 2D elements 6232.06 ms 6191.13 ms 0.6611% 🚨
hilite 50k functional 2D elements (P95 of main thread blocks) 35 ms 37 ms -5.4054% ✅
compute selection for 50k elements 312.91 ms 308.31 ms 1.4920% 🚨
compute selection for 50k elements (P95 of main thread blocks) 31 ms 31 ms 0% 🟰
compute parent selection for 50k elements 348.71 ms 347.72 ms 0.2847% 🚨
compute parent selection for 50k elements (P95 of main thread blocks) 31 ms 31 ms 0% 🟰
compute top ancestor selection for 50k elements 562.69 ms 560.16 ms 0.4517% 🚨
compute top ancestor selection for 50k elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute category selection for 50k elements 90.66 ms 102.18 ms -11.2742% ✅
compute category selection for 50k elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute model selection for 50k elements 80.49 ms 76.64 ms 5.0235% 🚨
compute model selection for 50k elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute functional selection for 50k 3D elements 404.42 ms 444.57 ms -9.0312% ✅
compute functional selection for 50k 3D elements (P95 of main thread blocks) 31 ms 33 ms -6.0606% ✅
compute parent functional selection for 50k 3D elements 447.53 ms 441.08 ms 1.4623% 🚨
compute parent functional selection for 50k 3D elements (P95 of main thread blocks) 31 ms 31 ms 0% 🟰
compute top ancestor functional selection for 50k 3D elements 1156.74 ms 1136.96 ms 1.7397% 🚨
compute top ancestor functional selection for 50k 3D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute functional selection for 50k 2D elements 3100.88 ms 2942.2 ms 5.3932% 🚨
compute functional selection for 50k 2D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute parent functional selection for 50k 2D elements 3062.47 ms 3017.71 ms 1.4832% 🚨
compute parent functional selection for 50k 2D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute top ancestor functional selection for 50k 2D elements 3122.2 ms 3001.27 ms 4.0293% 🚨
compute top ancestor functional selection for 50k 2D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

github-actions[bot] commented 2 months ago

Hierarchies benchmark

Benchmark suite Current: 9e90ae7e0b6e3d0d711dad7923a09513f7a0e5fa Previous: 05658f5c7a32f0a5ea08e6727e6f2542a0125c51 Deviation Status
flat 50k elements list 4289.94 ms 4146.57 ms 3.4576% 🚨
flat 50k elements list (P95 of main thread blocks) 75 ms 74 ms 1.3514% 🚨
grouping by label 10528.99 ms 10002.29 ms 5.2658% 🚨
grouping by label (P95 of main thread blocks) 70 ms 61 ms 14.7541% 🚨
grouping by class 10576.2 ms 10248.82 ms 3.1943% 🚨
grouping by class (P95 of main thread blocks) 47 ms 45 ms 4.4444% 🚨
grouping by property 11041.57 ms 10715.54 ms 3.0426% 🚨
grouping by property (P95 of main thread blocks) 49 ms 67 ms -26.8657% ✅
grouping by base class (10 classes) 7813.47 ms 7474.15 ms 4.5399% 🚨
grouping by base class (10 classes) (P95 of main thread blocks) 86 ms 82 ms 4.8780% 🚨
grouping by multiple attributes 28226.31 ms 27052.99 ms 4.3371% 🚨
grouping by multiple attributes (P95 of main thread blocks) 69 ms 54 ms 27.7778% 🚨
hide if no children required to finalize root, w/o children 50440 ms 45774.59 ms 10.1921% 🚨
hide if no children required to finalize root, w/o children (P95 of main thread blocks) 40 ms 38 ms 5.2632% 🚨
hide if no children required to finalize root, w/ children 157.05 ms 157.97 ms -0.5824% ✅
hide if no children required to finalize root, w/ children (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
models tree initial (Baytown) 39.37 ms 40.93 ms -3.8114% ✅
models tree initial (Baytown) (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
models tree full (Baytown) 8155.87 ms 7645.58 ms 6.6743% 🚨
models tree full (Baytown) (P95 of main thread blocks) 92 ms 84 ms 9.5238% 🚨

This comment was automatically generated by workflow using github-action-benchmark.