search

iTwin / presentation

Monorepo for iTwin.js Presentation Library
https://www.itwinjs.org/presentation/
MIT License
4 stars 0 forks source link

Hierarchies-react: use `TreeNode` `onClick` and `onKeyDown` callbacks #660

Closed jasdom closed 1 month ago

jasdom commented 1 month ago

TreeNode now provides proper onClick and onKeyDown so wrapping the node is no longer necessary.

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 5465b5467cefd2bd8ebc46d8920c363db2d54e59

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------------------------------- | ----- | | @itwin/presentation-hierarchies-react | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 month ago

Unified selection benchmark

Benchmark suite Current: 5465b5467cefd2bd8ebc46d8920c363db2d54e59 Previous: b9598f6702bea0f466abae02378a0c958f8e5fe9 Deviation Status
hilite 50k elements 1281.19 ms 1197.81 ms 6.9610% 🚨
hilite 50k elements (P95 of main thread blocks) 44 ms 45 ms -2.2222% ✅
hilite 50k group elements 236.43 ms 241.39 ms -2.0548% ✅
hilite 50k group elements (P95 of main thread blocks) 31 ms 31 ms 0% 🟰
hilite 1k subjects 47363.54 ms 47428.79 ms -0.1376% ✅
hilite 1k subjects (P95 of main thread blocks) 27 ms 26 ms 3.8462% 🚨
hilite 50k subcategories 283.75 ms 280.51 ms 1.1550% 🚨
hilite 50k subcategories (P95 of main thread blocks) 33 ms 33 ms 0% 🟰
hilite 50k functional 3D elements 25672.97 ms 26510.05 ms -3.1576% ✅
hilite 50k functional 3D elements (P95 of main thread blocks) 33 ms 39 ms -15.3846% ✅
hilite 50k functional 2D elements 6118.87 ms 6091.73 ms 0.4455% 🚨
hilite 50k functional 2D elements (P95 of main thread blocks) 34 ms 37 ms -8.1081% ✅
compute selection for 50k elements 340.14 ms 309.3 ms 9.9709% 🚨
compute selection for 50k elements (P95 of main thread blocks) 35 ms 31 ms 12.9032% 🚨
compute parent selection for 50k elements 351.76 ms 348.94 ms 0.8082% 🚨
compute parent selection for 50k elements (P95 of main thread blocks) 33 ms 32 ms 3.1250% 🚨
compute top ancestor selection for 50k elements 553.65 ms 561.28 ms -1.3594% ✅
compute top ancestor selection for 50k elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute category selection for 50k elements 88.98 ms 91.6 ms -2.8603% ✅
compute category selection for 50k elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute model selection for 50k elements 74.98 ms 90.55 ms -17.1949% ✅
compute model selection for 50k elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute functional selection for 50k 3D elements 397.35 ms 406.3 ms -2.2028% ✅
compute functional selection for 50k 3D elements (P95 of main thread blocks) 31 ms 31 ms 0% 🟰
compute parent functional selection for 50k 3D elements 442.63 ms 449.19 ms -1.4604% ✅
compute parent functional selection for 50k 3D elements (P95 of main thread blocks) 31 ms 31 ms 0% 🟰
compute top ancestor functional selection for 50k 3D elements 1131.65 ms 1147.78 ms -1.4053% ✅
compute top ancestor functional selection for 50k 3D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute functional selection for 50k 2D elements 2964.67 ms 3034.42 ms -2.2986% ✅
compute functional selection for 50k 2D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute parent functional selection for 50k 2D elements 3044.09 ms 3011.11 ms 1.0953% 🚨
compute parent functional selection for 50k 2D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute top ancestor functional selection for 50k 2D elements 3014.18 ms 2995.01 ms 0.6401% 🚨
compute top ancestor functional selection for 50k 2D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

github-actions[bot] commented 1 month ago

Hierarchies benchmark

Benchmark suite Current: 5465b5467cefd2bd8ebc46d8920c363db2d54e59 Previous: b9598f6702bea0f466abae02378a0c958f8e5fe9 Deviation Status
flat 50k elements list 4170.08 ms 4090.82 ms 1.9375% 🚨
flat 50k elements list (P95 of main thread blocks) 73 ms 70 ms 4.2857% 🚨
grouping by label 10001.7 ms 9810.32 ms 1.9508% 🚨
grouping by label (P95 of main thread blocks) 62 ms 57 ms 8.7719% 🚨
grouping by class 10065.86 ms 9948.61 ms 1.1786% 🚨
grouping by class (P95 of main thread blocks) 46 ms 39 ms 17.9487% 🚨
grouping by property 10814.41 ms 10461.93 ms 3.3692% 🚨
grouping by property (P95 of main thread blocks) 48 ms 83 ms -42.1687% ✅
grouping by base class (10 classes) 7588.3 ms 7184.68 ms 5.6178% 🚨
grouping by base class (10 classes) (P95 of main thread blocks) 81 ms 72 ms 12.5000% 🚨
grouping by multiple attributes 27135.77 ms 26658.02 ms 1.7921% 🚨
grouping by multiple attributes (P95 of main thread blocks) 47 ms 47 ms 0% 🟰
hide if no children required to finalize root, w/o children 49447.61 ms 45797.8 ms 7.9694% 🚨
hide if no children required to finalize root, w/o children (P95 of main thread blocks) 39 ms 38 ms 2.6316% 🚨
hide if no children required to finalize root, w/ children 152.29 ms 152.33 ms -0.0263% ✅
hide if no children required to finalize root, w/ children (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
models tree initial (Baytown) 39.15 ms 38.34 ms 2.1127% 🚨
models tree initial (Baytown) (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
models tree full (Baytown) 7686.2 ms 7571.11 ms 1.5201% 🚨
models tree full (Baytown) (P95 of main thread blocks) 86 ms 87 ms -1.1494% ✅

This comment was automatically generated by workflow using github-action-benchmark.