search

iTwin / presentation

Monorepo for iTwin.js Presentation Library
https://www.itwinjs.org/presentation/
MIT License
4 stars 0 forks source link

`components`: API promotions #662

Closed grigasp closed 1 month ago

grigasp commented 1 month ago

Part of https://github.com/iTwin/itwinjs-backlog/issues/1103.

@saskliutas, can you please have a look at packages\components\src\presentation-components\properties\editors\NavigationPropertyEditorContext.ts? navigationPropertyEditorContext is exposed as public, although createContext results are generally internal elsewhere - I wasn't sure we want to make it public or internal.

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 32f38d898541a5c04e2b67bdea97483accf44d7a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ------------------------------ | ----- | | @itwin/presentation-components | Minor | | @itwin/presentation-testing | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

grigasp commented 1 month ago

I think navigationPropertyEditorContext should be internal. There is no reason it should be used outside NavigationPropertEditor.

Made the change, please review.