search

iTwin / presentation

Monorepo for iTwin.js Presentation Library
https://www.itwinjs.org/presentation/
MIT License
4 stars 0 forks source link

Hierarchies: Allow disabling expansion to filter targets #676

Closed jasdom closed 1 month ago

jasdom commented 1 month ago

Closes https://github.com/iTwin/presentation/issues/673.

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 68fd87be616296f4a2009e548aacdecea4ca22bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ------------------------------------- | ----- | | @itwin/presentation-hierarchies | Minor | | @itwin/presentation-hierarchies-react | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 month ago

Hierarchies benchmark

Benchmark suite Current: 68fd87be616296f4a2009e548aacdecea4ca22bf Previous: 26ccbfb16a492d896a9df273ecc798480cb88442 Deviation Status
flat 50k elements list 4110.28 ms 4118.65 ms -0.2032% ✅
flat 50k elements list (P95 of main thread blocks) 71 ms 73 ms -2.7397% ✅
grouping by label 9950.18 ms 9962.47 ms -0.1234% ✅
grouping by label (P95 of main thread blocks) 64 ms 64 ms 0% 🟰
grouping by class 10040.55 ms 9947.44 ms 0.9360% 🚨
grouping by class (P95 of main thread blocks) 43 ms 45 ms -4.4444% ✅
grouping by property 10640.7 ms 10601.1 ms 0.3735% 🚨
grouping by property (P95 of main thread blocks) 79 ms 50 ms 58.0000% 🚨
grouping by base class (10 classes) 7484.89 ms 7392.68 ms 1.2473% 🚨
grouping by base class (10 classes) (P95 of main thread blocks) 77 ms 136 ms -43.3824% ✅
grouping by multiple attributes 27612.84 ms 26979.62 ms 2.3470% 🚨
grouping by multiple attributes (P95 of main thread blocks) 39 ms 51 ms -23.5294% ✅
hide if no children required to finalize root, w/o children 48309.96 ms 44337.75 ms 8.9590% 🚨
hide if no children required to finalize root, w/o children (P95 of main thread blocks) 41 ms 36 ms 13.8889% 🚨
hide if no children required to finalize root, w/ children 166.43 ms 155.64 ms 6.9327% 🚨
hide if no children required to finalize root, w/ children (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
models tree initial (Baytown) 39.37 ms 43.75 ms -10.0114% ✅
models tree initial (Baytown) (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
models tree full (Baytown) 8136.53 ms 7612.29 ms 6.8868% 🚨
models tree full (Baytown) (P95 of main thread blocks) 90 ms 84 ms 7.1429% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

saskliutas commented 1 month ago

LGTM. @saskliutas, got any concerns?

No, looks good.