search

iTwin / presentation

Monorepo for iTwin.js Presentation Library
https://www.itwinjs.org/presentation/
MIT License
5 stars 0 forks source link

Update models tree definition to the latest version #771

Closed grigasp closed 2 weeks ago

grigasp commented 2 weeks ago

Copied from https://github.com/iTwin/viewer-components-react/tree/master/packages/itwin/tree-widget/src/components/trees/models-tree to make sure out test app and tests use the latest version.

changeset-bot[bot] commented 2 weeks ago

⚠️ No Changeset found

Latest commit: 2da8d77e8a6d5fd4a42402b037dcd5983ac4ef49

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 2 weeks ago

Unified selection benchmark

Benchmark suite Current: 2da8d77e8a6d5fd4a42402b037dcd5983ac4ef49 Previous: d2120c19087fb49ef91317650363f1add7b68701 Deviation Status
hilite 50k elements 1245.19 ms 1217.98 ms 2.2340% 🚨
hilite 50k elements (P95 of main thread blocks) 45 ms 44 ms 2.2727% 🚨
hilite 50k group elements 248.03 ms 242.61 ms 2.2340% 🚨
hilite 50k group elements (P95 of main thread blocks) 31 ms 33 ms -6.0606% ✅
hilite 1k subjects 44922.48 ms 44922.11 ms 0.0008% 🚨
hilite 1k subjects (P95 of main thread blocks) 28 ms 31 ms -9.6774% ✅
hilite 50k subcategories 285.03 ms 281.29 ms 1.3296% 🚨
hilite 50k subcategories (P95 of main thread blocks) 34 ms 33 ms 3.0303% 🚨
hilite 50k functional 3D elements 25349.52 ms 25349.91 ms -0.0015% ✅
hilite 50k functional 3D elements (P95 of main thread blocks) 42 ms 37 ms 13.5135% 🚨
hilite 50k functional 2D elements 6046.42 ms 6014.29 ms 0.5342% 🚨
hilite 50k functional 2D elements (P95 of main thread blocks) 33 ms 37 ms -10.8108% ✅
compute selection for 50k elements 299.16 ms 307.43 ms -2.6900% ✅
compute selection for 50k elements (P95 of main thread blocks) 31 ms 31 ms 0% 🟰
compute parent selection for 50k elements 333.9 ms 354.02 ms -5.6833% ✅
compute parent selection for 50k elements (P95 of main thread blocks) 33 ms 31 ms 6.4516% 🚨
compute top ancestor selection for 50k elements 555.42 ms 561.55 ms -1.0916% ✅
compute top ancestor selection for 50k elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute category selection for 50k elements 87.15 ms 88.52 ms -1.5477% ✅
compute category selection for 50k elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute model selection for 50k elements 74.9 ms 86.48 ms -13.3904% ✅
compute model selection for 50k elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute functional selection for 50k 3D elements 401.17 ms 405.06 ms -0.9604% ✅
compute functional selection for 50k 3D elements (P95 of main thread blocks) 32 ms 31 ms 3.2258% 🚨
compute parent functional selection for 50k 3D elements 432.04 ms 481.72 ms -10.3130% ✅
compute parent functional selection for 50k 3D elements (P95 of main thread blocks) 31 ms 35 ms -11.4286% ✅
compute top ancestor functional selection for 50k 3D elements 1125.65 ms 1166.71 ms -3.5193% ✅
compute top ancestor functional selection for 50k 3D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute functional selection for 50k 2D elements 2967.88 ms 3146.32 ms -5.6714% ✅
compute functional selection for 50k 2D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute parent functional selection for 50k 2D elements 2967.43 ms 3203.31 ms -7.3636% ✅
compute parent functional selection for 50k 2D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute top ancestor functional selection for 50k 2D elements 3009.71 ms 3046.85 ms -1.2190% ✅
compute top ancestor functional selection for 50k 2D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

github-actions[bot] commented 2 weeks ago

Hierarchies benchmark

Benchmark suite Current: 2da8d77e8a6d5fd4a42402b037dcd5983ac4ef49 Previous: 6bc034ae293801ad27f1547baa1fb58745d7dd70 Deviation Status
flat 50k elements list 4837.92 ms 4861.81 ms -0.4914% ✅
flat 50k elements list (P95 of main thread blocks) 77 ms 77 ms 0% 🟰
filtering filters with 50000 paths 14225.88 ms 14366.77 ms -0.9807% ✅
filtering filters with 50000 paths (P95 of main thread blocks) 128 ms 134 ms -4.4776% ✅
grouping by label 11203.58 ms 11048.54 ms 1.4033% 🚨
grouping by label (P95 of main thread blocks) 74 ms 63 ms 17.4603% 🚨
grouping by class 11243.64 ms 11163.07 ms 0.7218% 🚨
grouping by class (P95 of main thread blocks) 34 ms 35 ms -2.8571% ✅
grouping by property 11969.83 ms 11766.96 ms 1.7241% 🚨
grouping by property (P95 of main thread blocks) 64 ms 52 ms 23.0769% 🚨
grouping by base class (10 classes) 8676.22 ms 8311.47 ms 4.3885% 🚨
grouping by base class (10 classes) (P95 of main thread blocks) 70 ms 67 ms 4.4776% 🚨
grouping by multiple attributes 30033.86 ms 29247.72 ms 2.6879% 🚨
grouping by multiple attributes (P95 of main thread blocks) 56 ms 38 ms 47.3684% 🚨
hide if no children required to finalize root, w/o children 59383.93 ms 53592.93 ms 10.8055% 🚨
hide if no children required to finalize root, w/o children (P95 of main thread blocks) 37 ms 51 ms -27.4510% ✅
hide if no children required to finalize root, w/ children 214.32 ms 181.66 ms 17.9786% 🚨
hide if no children required to finalize root, w/ children (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
models tree initial (Baytown) 47.47 ms 45.39 ms 4.5825% 🚨
models tree initial (Baytown) (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
models tree full (Baytown) 8113.28 ms 7986.42 ms 1.5884% 🚨
models tree full (Baytown) (P95 of main thread blocks) 86 ms 88 ms -2.2727% ✅

This comment was automatically generated by workflow using github-action-benchmark.