search

iTwin / presentation

Monorepo for iTwin.js Presentation Library
https://www.itwinjs.org/presentation/
MIT License
5 stars 0 forks source link

Function normalizeFullClassName assert fails when selecting transient id #775

Closed a-gagnon closed 1 week ago

a-gagnon commented 2 weeks ago

Hi. Please make sure the selection of transient element ids works properly.

The following assert fails in pineapple (call originates from measure-tools-react) when we attempt to select a measurement (transient element). https://github.com/iTwin/presentation/blob/9374049632acf91de7018d02b49660b11e53caa6/packages/shared/src/shared/Utils.ts#L27

Here is what the function receives as argument: Image

Not sure about this package specifically, but selecting transient elements use to work properly in the past.

Thanks, Alex

grigasp commented 2 weeks ago

Hi, @a-gagnon. The problem is already fixed with this PR and released with @itwin/unified-selection@1.1.1. I guess we'll need Pineapple to bump their dependency? @jason-crow

jason-crow commented 2 weeks ago

Hi, @a-gagnon. The problem is already fixed with this PR and released with @itwin/unified-selection@1.1.1. I guess we'll need Pineapple to bump their dependency? @jason-crow

yes we will get that pulled into pineapple

grigasp commented 2 weeks ago

@a-gagnon, I'll keep this issue open until you confirm the issue is fixed. Please get back to us when Pineapple consumes the fix and you give it a go.

grigasp commented 1 week ago

didn't get any response for a week - closing the issue