search

iTwin / viewer-components-react

Components built on iTwin.js for usability in an iTwin.js based Viewer.
MIT License
24 stars 34 forks source link

Property grid imports `@itwin/presentation-common` as a dev dependency but doesn't treat it as such #1006

Closed johnnyd710 closed 3 months ago

johnnyd710 commented 3 months ago

In packages/itwin/property-grid/src/PropertyGridUiItemsProvider.tsx, Key is imported from @itwin/presentation-common but @itwin/presentation-common is listed as a devDependency. 

import { Key } from "@itwin/presentation-common";
{
 "devDependencies": {
    // ...
    "@itwin/presentation-common": "^4.4.0",
    // ...
   },
}

Not sure if this is supposed to be a type import - otherwise @itwin/presentation-common should be listed as a dependency or peerDep

aruniverse commented 3 months ago

Looks like not used just for types, https://github.com/iTwin/viewer-components-react/blob/master/packages/itwin/property-grid/src/PropertyGridUiItemsProvider.tsx#L89

saskliutas commented 3 months ago

@johnnyd710 Published @itwin/property-grid-react@1.11.0 with fixed dependencies