search

iTwin / viewer-components-react

Components built on iTwin.js for usability in an iTwin.js based Viewer.
MIT License
24 stars 33 forks source link

Tree widget: Package cleanup #966

Closed grigasp closed 2 weeks ago

grigasp commented 2 weeks ago

Closes https://github.com/iTwin/viewer-components-react/issues/950

grigasp commented 2 weeks ago

Just a note but we probably want to have an e2e test for ModelsTree were search finds some matching nodes.

I believe this one does what you want, no? https://github.com/iTwin/viewer-components-react/blob/cf4d0a61699c13495b39ceae0b90636ae19a3768/packages/itwin/tree-widget/src/e2e-tests/ModelsTree.test.ts#L54

saskliutas commented 2 weeks ago

Just a note but we probably want to have an e2e test for ModelsTree were search finds some matching nodes.

I believe this one does what you want, no?

https://github.com/iTwin/viewer-components-react/blob/cf4d0a61699c13495b39ceae0b90636ae19a3768/packages/itwin/tree-widget/src/e2e-tests/ModelsTree.test.ts#L54

This one applies hierarchy level filter. We need test for searching by label.

grigasp commented 2 weeks ago

Just a note but we probably want to have an e2e test for ModelsTree were search finds some matching nodes.

I believe this one does what you want, no? https://github.com/iTwin/viewer-components-react/blob/cf4d0a61699c13495b39ceae0b90636ae19a3768/packages/itwin/tree-widget/src/e2e-tests/ModelsTree.test.ts#L54

This one applies hierarchy level filter. We need test for searching by label.

added