iTwin / viewer-components-react

Components built on iTwin.js for usability in an iTwin.js based Viewer.
MIT License
24 stars 33 forks source link

[measure-tools] Resolve no-internal warnings #989

Closed DanRod1999 closed 1 month ago

DanRod1999 commented 1 month ago

Address all problems flagged by eslint no-internal. Current status:

### internal - occurrences - solution
- [x] method ToolAdmin.fillEventFromLastDataButton - 2 - update itwin packages to 4.7
- [x] method AccuSnap.getCurrSnapDetail - 2 - update itwin packages to 4.7
- [x] method AccuDrawHintBuilder.- 1 - use AccuDrawHintBuilder.setMatrix
- [x] method IModelConnection.requestSnap - 1 - use  AccuSnap.doSnapRequest
- [x] interface SnapResponseProps - 12 - resolved after switching to AccuSnap.doSnapRequest
- [x] class ToolSettingsState - 2 - update itwin packages to 4.7
- [x] property ToolAdmin.toolSettingsState - 2 - update itwin packages to 4.7
- [x] class TentativeOrAccuSnap - 2 - update itwin packages to 4.7
### beta - occurrences - solution
- [ ] method ViewManager.invalidateCachedDecorationsAllViews - 1
- [x] method IModelConnection.createQueryReader - 2 - update itwin packages to 4.7
- [ ] function Toolbar - 1

Total occurrences across functions +----------+------------------+ | Tag | # of Occurrences | +----------+------------------+ | internal | 24 | +----------+------------------+ | beta | 4 | +----------+------------------+

DanRod1999 commented 1 month ago

Most off the methods flagged were resolved just by updating to a newer version of itwinjs. This issue goes over most of these changes https://github.com/iTwin/itwinjs-backlog/issues/782