search

iTwin / viewer

Monorepo that contains the iTwin Viewer npm packages and their related packages
MIT License
25 stars 16 forks source link

tsconfig es2020 node #180

Closed samejima-san closed 1 year ago

samejima-san commented 2 years ago

Changing tsconfig files: 'target' to 'es2020'

CLAassistant commented 2 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
5 out of 6 committers have signed the CLA.

:white_check_mark: aruniverse
:white_check_mark: samejima-san
:white_check_mark: johnnyd710
:white_check_mark: kckst8
:white_check_mark: achrysaetos
:x: iTwinViewerWorkflow

iTwinViewerWorkflow seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

samejima-san commented 2 years ago

targetting wrong branch

I know, i have to switch it on the web version but publish from cli

aruniverse commented 2 years ago

Have you run the test-app (the one in packages/apps/web-viewer-test)?

I'm running into this locally: image

aruniverse commented 2 years ago

Have you run the test-app (the one in packages/apps/web-viewer-test)?

I'm running into this locally: image

Looks like we need to update to webpack 5, which should be ok imo Need to update dep on @bentley/react-scripts to 5.0.0-dev.4 in the test app and templates, but I'll wait on Kevin to approve that.

aruniverse commented 1 year ago

closing this pr, too many conflicts, will just redo whats necessary for 4.0 release