Closed GytisCepk closed 1 year ago
ive been going back and forth so much with this pr; i hate peer deps and statics sooo so much.
redux/react-redux changes look fine
re the imodels-* pkgs:
devDeps
heres a partial patch of what i think the changes should probably look like viewer-imodels-pr.txt
lmk what your thoughts are
heres a partial patch of what i think the changes should probably look like viewer-imodels-pr.txt
looks like in my patch, i removed the direct dep in web-viewer & desktop-viewer react and just kept the direct deps at the test app/template levels. so the opposite of what i said yesterday... idk what was going on when i was wiritng that out yesterday.... sorry
in the patch, the imodels-client-management copies what we do for imodels-access-frontend.
as mentioned in todays call someone does need to have a direct dep on the client pkg, either web/desktop-viewer or the test app. im questioning if the imodels-access-frontend should be a direct dep in the web/desktop as well if we make the client a direct dep. im going to approve this pr for now, but i think we need to take a better look at these deps when we update to the 2.x imdoels pkgs
Changes:
Add missing redux and react-redux dependencies (peer dependencies of @itwin/appui-react):
UiFramework
static class.Add @itwin/imodels-client-management as peer dependency in @itwin/viewer-react package: