Show progress indicator during changesets download

iTwin / viewer

Monorepo that contains the iTwin Viewer npm packages and their related packages

MIT License

24 stars 15 forks source link

Show progress indicator during changesets download #227

Closed GytisCepk closed 1 year ago

GytisCepk commented 1 year ago

Changes:

[Breaking change] Increased iTwin.Js minimum version to 3.6.
[Breaking change] Increased imodels-clients packages minimum version to 2.2.1.
[Breaking change] Dropped Electron 14 and started using Electron 22.
Use new OnProgressCallback type function when downloading briefcases.
Report progress when downloading changes: Example:

GytisCepk commented 1 year ago

Closes #209

GytisCepk commented 1 year ago

If you're bumping dev deps don't you need to also update peer deps?

Do we have some sort of policy to keep peer and dev dependencies versions identical ?

iTwinJs 3.5 only required in template and I don't think it's a breaking change to bump version there. iTwinJs 3.5 is not required in packages, but because of how rush works, I need to bump version in them as well and, since bumping peer dependencies would be breaking change, I only bumped dev dependencies.

aruniverse commented 1 year ago

iTwinJs 3.5 is not required in packages, but because of how rush works, I need to bump version in them as well

Stupid Rush.

I think theres a setting we can use to get around this for the time being.

In Rush.json

 "ensureConsistentVersions": false,

aruniverse commented 1 year ago

gytis, since we're going to be working on a new major ver of the viewer, mind re-targeting the branch to next instead of master?

in there it should be ok to update the min peer dep to 3.6 or whatever we use