search

iTwin / viewer

Monorepo that contains the iTwin Viewer npm packages and their related packages
MIT License
24 stars 15 forks source link

Prep browser authorization 1.0 #246

Closed ben-polinsky closed 1 year ago

ben-polinsky commented 1 year ago

Contains changes needed to upgrade the test web viewer app and cra template to @itwin/browser-authorization@1.0

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

ben-polinsky commented 1 year ago

I had to set legacy-peer-deps to true to get the template to build locally -- related to the new dev packages and some still having a peer of 3.x set (i.e. not related to new auth packages)

ben-polinsky commented 1 year ago

Tons of desktop viewer lint warnings are failing the build. Many dependency array issues... have to think our eslint package change altered this?

aruniverse commented 1 year ago

Tons of desktop viewer lint warnings are failing the build. Many dependency array issues... have to think our eslint package change altered this?

gah, my bad, added lint to the pipeline since we werent doing it before didnt realize that warnings would fail the build here, there is a rush setting to allow warnings in a succesful build tht we might want to set

we should def look at the lint warnings, but can do that in a separate pr