iTwin / viewer

Monorepo that contains the iTwin Viewer npm packages and their related packages
MIT License
24 stars 15 forks source link

rpc registration changes for desktop #258

Closed aruniverse closed 1 year ago

aruniverse commented 1 year ago

react to core-breaking changes wrt electron rpc registration

aruniverse commented 1 year ago

@ben-polinsky @calebmshafer , what do you think about the following breaking change:

Right now we have viewerRpcs in packages/apps/desktop-viewer-test/src/common/ViewerConfig.ts, which is in the common dir so it can be shared by both frontend and backend. Thoughts on:

the proposed changes are in https://github.com/iTwin/viewer/pull/258/commits/f957b352dcbc0cebdfdf547a0543523bf6c1634e, which i can drop if we don't like