Update desktop-test-app and template to use iui-layouts

iTwin / viewer

Monorepo that contains the iTwin Viewer npm packages and their related packages

MIT License

24 stars 15 forks source link

Update desktop-test-app and template to use iui-layouts #300

Closed AnDuong249 closed 9 months ago

AnDuong249 commented 9 months ago

Update the desktop-test-app and the cra-template-desktop-viewer to use itwinui-layouts-react
Fix css for SelectItwin component
Replaced LabeledInput with SearchBox in SelectItwin.tsx
Clean up unnecessary css

Before: After:

aruniverse commented 9 months ago

issues:

sign in pg not centered:
hoping you can fix the tabs here so theyre not vertical

aruniverse commented 9 months ago

this pr, can still use some work; take a look at this layout: https://itwin.github.io/iTwinUI-layouts/#/page-layout-2

also, fix the ci failure coming from i imagine is the audit failure

AnDuong249 commented 9 months ago

this pr, can still use some work; take a look at this layout: https://itwin.github.io/iTwinUI-layouts/#/page-layout-2

also, fix the ci failure coming from i imagine is the audit failure

Should I make a separate PR to bump it like Ben did in core yesterday?

aruniverse commented 9 months ago

this pr, can still use some work; take a look at this layout: itwin.github.io/iTwinUI-layouts/#/page-layout-2 also, fix the ci failure coming from i imagine is the audit failure

Should I make a separate PR to bump it like Ben did in core yesterday?

you could just do it in here