Add ability to initialize Presentation with custom props

iTwin / viewer

Monorepo that contains the iTwin Viewer npm packages and their related packages

MIT License

24 stars 15 forks source link

Add ability to initialize Presentation with custom props #314

Closed saskliutas closed 1 month ago

saskliutas commented 1 month ago

Added ability to supply custom props to use during Presentation initialization. This is need to allow supplying new unified selection storage to be used by presentation-frontend.

Remove code setting active locale as it is done by default when initializing Presentation: https://github.com/iTwin/itwinjs-core/blob/73187a864fe12a1ca44d38f799bc9a2d79dfa40a/presentation/frontend/src/presentation-frontend/Presentation.ts#L74

ben-polinsky commented 1 month ago

Looks good to me. We'll need to mitigate this audit failure:

ERROR: HIGH Security Vulnerability: Path traversal in webpack-dev-middleware in webpack-dev-middleware (from ....packagesappsdesktop-viewer-test>@bentley/react-scripts>webpack-dev-server>webpack-dev-middleware). See https://github.com/advisories/GHSA-wr3j-pwj9-hqq6 for more info.