search

iUltimateLP / unreal-git-push

Unreal Engine 4 Git Push Plugin - Extends the User Interface of the editor
MIT License
5 stars 2 forks source link

Needs modernizing and partial rewriting #1

Open OdinVex opened 2 years ago

OdinVex commented 2 years ago

This project needs some rewriting to work with the latest versions of Unreal Engine. Most of its compile issues are relating to how everything is #included, or slate deprecations, but there is also the issue of UE_LOG not working correctly for this plugin.

I'd like to make note that some use Linux. Just allow us to specify a path to the binary for git, and we're content. I've gotten it to compile (a bit of tinkering definitely required) for Linux, hopefully it'll work.

OdinVex commented 2 years ago

Adding a follow up: https://github.com/OdinVex/unreal-git-push/commit/62631dfe8465b73b1f1fed4e7e9ae81052fef5a0#commitcomment-67861467

I got it working on Linux, assumed still working with Windows, and untested Mac. It works on UE >= 4.25 as well. Note: You assumed local branches are master when they could be anything. I'm thinking about rewriting it to including a refresh button to:

1. List all local branches.
2. List all remote hosts.
3. List all remote branches specific to each remote host.
4. Allow you to push to any.
5. Optionally assume signing (GPG).
6. Allow refreshing 1-3 to reflect any environmental changes.

If I get around to it. ^_^;

iUltimateLP commented 2 years ago

Thanks! Unfortunately, I really don't find the time to further support this plugin, but I'm happy for the contribution!

OdinVex commented 2 years ago

Thanks! Unfortunately, I really don't find the time to further support this plugin, but I'm happy for the contribution!

I'll try to find some time to test on Windows, it should already work on Mac (untested, but the shell is quite similar to Linux). I've got it working flawlessly on Linux, though I'm wondering how I might want to implement everything without trying to invent a whole git client. :thinking:

As for the master bit in the code, it was never necessary in the way it was being used and people have begun to move away from the whole 'master and slave' terminology anyway, which is nice. :peace_symbol: Other than that, the plugin just needed refreshing past 4.25 and shell fixes, easily compared in my current temporary fork.