search

iVantage / angular-ivh-treeview

A treeview for AngularJS with filtering and checkbox support.
http://ivantage.github.io/angular-ivh-treeview/
MIT License
238 stars 89 forks source link

Default template should not render collapsed children #190

Open jtrussell opened 7 years ago

jtrussell commented 7 years ago

I.e. the second suggestion here should just be the default.

Probably should address #84.

kuroky360 commented 7 years ago

Is Angular's bind-once syntx the best workaround for the performance now?

jtrussell commented 7 years ago

Using ng-if to not render collapsed children can give a huge performance boost - bind-once would be interesting to experiment with.

kuroky360 commented 7 years ago

Ok,so the next work is using ng-if to not render collapsed children for the v2.

jtrussell commented 7 years ago

Yep, the bulk of the work will be in updating the tests to not rely on a particular template - many tests will break with this change :(.

kuroky360 commented 7 years ago

Thanks for your all effort !

jtrussell commented 7 years ago

Feel free to dig in if you like :). You can submit PR's against the v2 branch.

kuroky360 commented 7 years ago

Yes,I will ~

fhurta commented 7 years ago

@Kuroky360 any progress with the performance boost? I'm hitting the limit too and the improvement would be very appreciated

kuroky360 commented 7 years ago

@fhurta sorry for that