iVis-at-Bilkent / cytoscape.js-clipboard

A Cytoscape.js extension to provide copy-paste utilities

MIT License

8 stars 4 forks source link

fixed #8 #15

Closed AsmaJodeiri closed 3 years ago

AsmaJodeiri commented 3 years ago

8

hasanbalci commented 3 years ago

@AsmaJodeiri The selection problem seems solved. I realized a few problems with undo-redo:

When we select a node and cut it, edges connected to that node are also removed. When we undo the operation, the node is restored but edges removed aren't restored. For a correct undo operation, those edges should be restored as well.
Another issue with undo-redo is: For example, I cut a node and then pasted it. If I undo the paste operation, then I should be able to paste it again. Currently, it cannot be done.

If you have questions about how the undo-redo extension works, you can ask me.

AsmaJodeiri commented 3 years ago

@hasanbalci I have added a version of cut which the undo-redo parts are fixed based on what you said but I am not sure how should edges act when a node is cuted. can you run the code and tell me if this is right or how should the edges act after cut?

hasanbalci commented 3 years ago

@AsmaJodeiri The functionality seems ok now. Maybe you can do the following to fix the format of the files:

Get the original files (README.md, cytoscape-clipboard.js and demo.html) from the unstable branch
Just apply your changes to the required places of the files without applying any formatting by you or your IDE
Copy the updated files into your own copy of the repository and commit.

Hopefully, we can see only the actual changes in this way while keeping the original format. Additionally, it seems there are console log statements remaining in cytoscape-clipboard.js file, please remove them as well.