search

iVis-at-Bilkent / cytoscape.js-fcose

fCoSE: a fast Compound Spring Embedder
MIT License
134 stars 25 forks source link

Empty compounds mess up layout #60

Closed ugurdogrusoz closed 1 year ago

ugurdogrusoz commented 1 year ago

Looks like when there are empty compound nodes in the graph, these compound nodes are not taken into account, messing up the layout.

hasanbalci commented 1 year ago

The problem was because of the hidden nodes in the compounds which make them empty. Now, user should give all elements to the layout including the hidden ones, but the layout will not consider hidden ones during the layout (actually spectral part considers but cose part doesn't consider).

ugurdogrusoz commented 1 year ago

@hasanbalci thanks I confirm the fix with the extension demo. @osamazafar980 can you please check this in IAM application as well (please note the comment above for its usage).

osamazafar980 commented 1 year ago

I am still seeing some issues. The empty compound nodes are creating massive gaps which then gets overlapped by other compounds

ugurdogrusoz commented 1 year ago

@osamazafar980 Please close this if you tested it