search

iVis-at-Bilkent / cytoscape.js-graphml

A Cytoscape.js extension to import from and export to GraphML format
MIT License
31 stars 8 forks source link

Layoutoptions aren't set correctly #3

Closed SebastianOpriel closed 5 years ago

SebastianOpriel commented 8 years ago

Bug:

var layoutOptT = typeof options.layoutBy;
if (layoutOptT == "string")
  cy.layout({name: "cose"});
else if (layoutOptT == "function")
  options.layoutBy();

must be:

var layoutOptT = typeof options.layoutBy;
if (layoutOptT != "string")
  cy.layout({name: "cose"});
else if (layoutOptT == "function")
  options.layoutBy();
metincansiper commented 7 years ago

@bastianleirpo I think that you mean it must be

var layoutOptT = typeof options.layoutBy;
if (layoutOptT != "string")
  cy.layout({name: options.layoutBy});
else if (layoutOptT == "function")
  options.layoutBy();

If so I realized this bug and fixed here (https://github.com/iVis-at-Bilkent/cytoscape.js-graphml/commit/026819924b43a9d84d2a508aae686b552ae0f66c#diff-30321755da65b185145ed63f223042a6R175) and we can close the issue.

hasanbalci commented 5 years ago

I think this is not an issue anymore, so I'm closing.