search

iVis-at-Bilkent / cytoscape.js-graphml

A Cytoscape.js extension to import from and export to GraphML format
MIT License
31 stars 8 forks source link

Changes for Cytoscape ^3.0.0 #9

Closed lukaszkostrzewa closed 5 years ago

lukaszkostrzewa commented 7 years ago

I would like to make the plugin compatible with Cytoscape.js v3. One issue I found is that in Cytoscape.js v2 layout function was actually running the layout whilst in v3 we need to call run method to apply the layout. I've also updated the version in package.json and peer dependency to Cytoscape.js.

metincansiper commented 7 years ago

@lukaszkostrzewa thanks for your effort. To make this extension compatible with v3 you should cover everything mentioned in https://github.com/cytoscape/cytoscape.js/issues/1092 I browsed quickly and was able to find out that this line (https://github.com/iVis-at-Bilkent/cytoscape.js-graphml/blob/c08af9043c136334e8d871286e52d87785a73b55/src/exporter.js#L60) is not v3 compatible. I just browsed quickly, there may be many others like this line. And note that your changes should be backward compatible for v2 compatibility. One last thing is that I realized that you increased the version number in package.json. In this extension, it is updated automatically while publishing a new version through the gulp file. I think that it should be reverted back.

hasanbalci commented 5 years ago

We have published a new version with Cytoscape.js v3 support. So I am closing this pull request.