Initialization pattern if used together with cytoscape.js-context-menus

iVis-at-Bilkent / cytoscape.js-grid-guide

A Cytsocape.js extension to provide a framework for grid interactions such as grid lines and snapping to grid, and guidelines and snap support for alignment of nodes.

MIT License

58 stars 9 forks source link

Initialization pattern if used together with cytoscape.js-context-menus #23

Closed shean42 closed 6 years ago

shean42 commented 7 years ago

While trying to use grid-guide and context-menus together I ran into the issue that the order of initialization of these extensions is crucial. To be more concrete:

First initializing context-menus and then grid-guide results in "TypeError: e is null" in cytoscape.js.
Initializing grid-guide first does not throw that error.

I suspect this is not intentional? :-)

ugurdogrusoz commented 7 years ago

@kinimesi Can you please take a look?

kinimesi commented 6 years ago

@shean42 Which version of Cytoscape.js are you using?

shean42 commented 6 years ago

v3.2.3

kinimesi commented 6 years ago

@shean42 Do you have the same problem in Cytoscape.js v3.1.5?

shean42 commented 6 years ago

v3.1.5 does not appear to have that issue!

kinimesi commented 6 years ago

@shean42 This was due to a bug is Cytoscape.js, see https://github.com/cytoscape/cytoscape.js/issues/1980. Should be fixed in Cytoscape.js v3.2.4. Can you verify and close? Thanks.

shean42 commented 6 years ago

Solved by v3.2.4, thanks!