iVis-at-Bilkent / cytoscape.js-grid-guide

A Cytsocape.js extension to provide a framework for grid interactions such as grid lines and snapping to grid, and guidelines and snap support for alignment of nodes.
MIT License
59 stars 9 forks source link

Replace ```for(node of nodes)``` usage with traditional array traversing #26

Closed metincansiper closed 7 years ago

metincansiper commented 7 years ago

I am working on automating the tests of CWC. The tests are written in qunit and I use node-qunit-phantomjs to make the html file dedicated for testing runnable through the command line.

However, it was problematic in sbgnviz.js and this extension. I found out that the problem for sbgnviz.js is caused by a basic syntax error and I fixed it with the following commit (https://github.com/iVis-at-Bilkent/sbgnviz.js/commit/68784540b0afb89653bc088fa0f9bb85696fb144) and attached the commit to a PR in sbgnviz.

The problem with this repository is related to usage of for(node of nodes) syntax. I am not sure but most probably it would be working for many of modern browsers. However, it is problematic in this case.

This PR proposes to replace the usage of for ... of with traditional for loops.