Improve initial placement of non-hiearchic part

iVis-at-Bilkent / cytoscape.js-hyse

Hybrid Spring Embedder

MIT License

1 stars 0 forks source link

Improve initial placement of non-hiearchic part #17

Closed ugurdogrusoz closed 1 year ago

ugurdogrusoz commented 1 year ago

We should improve the initial placement of the non-hierarchic components in the following ways:

[x] 1. Rather than using the right and left of the hierarchy only, let's use all four sides.
[x] 2. Also let's scatter these components to be of varying distance to the hierarchy so that they do not overlap.

hamzaislam101 commented 1 year ago

The compound nodes now do not overlap when initializing their positions. The new compound node being added is compared with nodes only on that side of the hierarchy. A check box 'Display initial positions' is added to the side menu, which you need to check and run the HySE layout that will only run the initial part of the layout and only display the initial positions of the nodes.

ugurdogrusoz commented 1 year ago

I think this is great but I have the following concerns/issues with the initial placement:

[x] 1. Sometimes two components do overlap or they are very close. We should fix this bug and also have some buffer between an undirected component and the hierarchy as well as a buffer between undirected components.

[x] 2. I am worried that we are not efficiently calculating the location of components based on placement of previous components. I hope we're not checking the location of all previously placed nodes one by one to determine the location of a new component. There should be a quicker way.
[x] 3. To better debug the initial positioning, can we also have one more flag "Randomize initial positions" (true by default) which determines whether or not to randomize the initial positions of individual nodes. If not checked, we should see all nodes in the same component on top of each other.

hamzaislam101 commented 1 year ago

There are a couple of methods that I have in mind to calculate the location of components, each with its drawback of course. We can discuss that on white board. Right now we are just checking the already added components on a specific side.

ugurdogrusoz commented 1 year ago

Much better, but I still see overlaps (here nodes n1,5,9,11,13,15,18 are on the hierarchy): Screenshot 2023-04-11 104332 overlap-bug.graphml.txt

hamzaislam101 commented 1 year ago

There is a calculation bug in the initial assignment code. It occurs randomly. I'm working to resolve it.

ugurdogrusoz commented 1 year ago

Is this resolved?

hamzaislam101 commented 1 year ago

Yes, this is the same as #19 .