iVis-at-Bilkent / sbgnviz.js

A web based visualization tool for process description maps in SBGN
http://www.cs.bilkent.edu.tr/~ivis/SBGNViz_sample_app/
GNU Lesser General Public License v3.0
35 stars 14 forks source link

Provide a Simple Sample that works with Webpack branch: SBML #216

Open GeorgeS2019 opened 2 years ago

GeorgeS2019 commented 2 years ago

https://github.com/iVis-at-Bilkent/sbgnviz.js-sample-app

This is really old and does not reflect the latest switch to the SBML branch based on webpack and babel-loader

GeorgeS2019 commented 2 years ago

For others who need to npm install this specific branch

npm install "https://github.com/iVis-at-Bilkent/sbgnviz.js.git#SBML" --save

npm WARN deprecated har-validator@5.1.5: this library is no longer supported
npm WARN deprecated xmldom@0.1.31: Deprecated due to CVE-2021-21366 resolved in 0.5.0
npm WARN deprecated xmldom@0.1.19: Deprecated due to CVE-2021-21366 resolved in 0.5.0
npm WARN deprecated uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated popper.js@1.16.1: You can find the new Popper v2 at @popperjs/core, this package is dedicated to the legacy v1

added 74 packages, and audited 75 packages in 3m

6 vulnerabilities (3 low, 2 moderate, 1 high)
GeorgeS2019 commented 2 years ago

reference

var sbgnviz = require('sbgnviz');
var cytoscape = require('cytoscape-for-sbgnviz');
var jQuery = require('jQuery');
var filesaver = require('file-saver');
var tippy = require('tippy.js');

Compared to

var sbgnviz = require('sbgnviz');
var filesaverjs = require('filesaverjs');
var cytoscape = require('cytoscape');
var jQuery = $ = require('jquery');
var tippy = require('tippy.js');
hasanbalci commented 2 years ago

@GeorgeS2019 You're right that https://github.com/iVis-at-Bilkent/sbgnviz.js-sample-app is quite old and we didn't maintain it for a long time. I think you want to use SBML branch on that sample app. However, SBML branch which aims to add SBML support is still under development, in other words it is not fully functional yet. After we finished the development in that branch, we may consider to update the sample app so that it supports the features that will come with SBML branch.

hasanbalci commented 2 years ago

@GeorgeS2019 You should be able webpack unstable branch.

GeorgeS2019 commented 2 years ago

@hasanbalci Sorry, today I was outside so I could not clearly explain.

I only have problem when trying npm run build using WebPack with these packages.

Individually, there is no problem with the sbml branch (Webpack). It is only trying to build bundle with the following combination.

var sbgnviz = require('sbgnviz');  <== sbml branch.
var cytoscape = require('cytoscape-for-sbgnviz');
var jQuery = require('jQuery');
var filesaver = require('file-saver');
var tippy = require('tippy.js');