iVis-at-Bilkent / software-artifact-analyzer

SAA: A tool to visually analyze varying software artifacts including source code files, pull requests, issues, and commits, as well as their links and their relationships with developers in a software project to improve the software development process
0 stars 0 forks source link

Display Issue Types in Node UIs #140

Closed LaraMerdol closed 3 months ago

LaraMerdol commented 5 months ago

Show issue types in node UIs and enable special filtering for them. Choose appropriate badges for that.

LaraMerdol commented 4 months ago

Jira standart issue types are;

Jira Work Management business projects issue types By default, business projects come with one standard issue type:

Jira software projects issue types By default, software projects come with one parent issue type:

By default, software projects come with three standard issue types:

By default, software projects come with one child issue type:

Jira Service Management (service projects) issue types

LaraMerdol commented 4 months ago

As a SAA design for software projects, we are going to use the following issue types and hierarchy. We have also decided to use Jira issue type icons to be consistent with Jira.Jira.

LaraMerdol commented 4 months ago
Screen Shot 2024-06-17 at 14 28 47
LaraMerdol commented 4 months ago

We also include issue types for Improvement and New Feature. A list of added issue types and their respective icons can be found below.

Epic = Epic Bug = Bug Story = Story Task = Task Sub-task = Sub-task Improvement = Improvement New Feature= New-feature other = other (custom issue types or others)

LaraMerdol commented 4 months ago
Screen Shot 2024-06-20 at 10 13 32 Screen Shot 2024-06-20 at 11 18 39
LaraMerdol commented 4 months ago

For issues with issue type other than selected ones Other;

Screen Shot 2024-06-20 at 13 04 27
LaraMerdol commented 4 months ago

Are we allowed to use Jira icons for node types? Check any license terms.

ugurdogrusoz commented 4 months ago

I think this looks great. Let's try moving both the issue type and the priority badges toward the outside of the node icon, barely touching the issue icon.

ugurdogrusoz commented 4 months ago

Let's also make sure that these badges (same with priority badges) are persistent and do not go away when the user removes highlights!

LaraMerdol commented 4 months ago

's also make sure that these badges (same with priority badges) are persistent and do not go away when the user removes highlights!

Fix the issue so that the proprietary badges and the typed badges do not disappear when cues are removed.

Screen Recording 2024-06-23 at 19 33 59

ugurdogrusoz commented 4 months ago

Let's also make sure that these badges (same with priority badges) are persistent and do not go away when the user removes highlights!

Only those badges (issue priority and type) that should be persistent should stay on remove highlights, not regular highlighting, not badges added by other facilities such as graph theoretic property metrics.

LaraMerdol commented 4 months ago

The style of the issued badges will be updated according to the comment.

Screen Shot 2024-06-25 at 09 58 08 Screen Shot 2024-06-25 at 09 58 27 Screen Shot 2024-06-25 at 09 58 49
ugurdogrusoz commented 4 months ago

The badges look great, thank you! Some issues:

Screenshot 2024-06-25 at 14 13 07
LaraMerdol commented 4 months ago

Fix subtask 3 align badges;

Screen Shot 2024-06-30 at 17 14 05
LaraMerdol commented 4 months ago

Fix subtask-3:

Change the addIssueBadges() function to take a size parameter addIssueBages (size: number = 18), with the default value of 18, which is a 0.5625 ratio with the issue node size (18/32). When adding badges, after calculating theoretical properties and adjusting node size, add issue type and priority badges according to the node's new size, while keeping the 0.5625 ratio.

Screen Recording 2024-06-30 at 17 19 05

LaraMerdol commented 4 months ago

Fix subtask 2: The badges are not aligned at the top of the context menu and their z-index has been reduced. Screen Recording 2024-06-30 at 17 29 53

LaraMerdol commented 4 months ago
  1. Now all badges and resizes, etc. are persistent on Remove Highlights. Normally, when we calculate a graph theoretic property and resize a node and put a badge and then apply Remove Highlights, things would go back to normal. We still want this except issue type and priority badges being persistent.

Could you clarify subtask-1 a little more? I'm not sure if it's related to resizing the issue badges after calculating theoretical properties or something else. @ugurdogrusoz

LaraMerdol commented 4 months ago

Also, I suggest removing anomaly badges when calculating theoretical properties because in that case, anomaly badges and theoretical property badges overlap, both appearing in the top right corner. Users can add later if they want to see them. Screen Recording 2024-06-30 at 15 33 42

ugurdogrusoz commented 4 months ago
  1. Now all badges and resizes, etc. are persistent on Remove Highlights. Normally, when we calculate a graph theoretic property and resize a node and put a badge and then apply Remove Highlights, things would go back to normal. We still want this except issue type and priority badges being persistent.

Could you clarify subtask-1 a little more? I'm not sure if it's related to resizing the issue badges after calculating theoretical properties or something else. @ugurdogrusoz

Here the confusion comes from the fact that we use badges (temporary annotations on nodes) to show the type and priority of an issue. Normally the badges are used for temporary annotations (e.g., anomaly counts and graph-theoretic property metrics). Hence, "Remove Highlights" should remove all temporary annotations including anomaly counts, graph-theoretic property metrics and should resize the node back to its normal size. The only thing that this operation shouldn't reverse is the type and priority badge of an issue since this is a permanent thing.

LaraMerdol commented 4 months ago

Fix subtask-1: Remove highlights, remove badges, and reset node size to original without affecting constant issue type and priority badges.

Screen Recording 2024-07-01 at 21 33 46

ugurdogrusoz commented 4 months ago

Added new items (5 & 6)

LaraMerdol commented 4 months ago

Fix subtask 6:S Anomalous behavior related to some graph-theoretic property calculation operations has no effect (no badges displayed) has been fiexed fixed.

Screen Recording 2024-07-09 at 17 09 18

LaraMerdol commented 4 months ago

Fix subtask 6: naming change

Screen Shot 2024-07-09 at 17 12 42
LaraMerdol commented 4 months ago

Fix sub-task 5 (Partially): Now, when graph theoretical properties are added, anomaly badges disappear. The problem is that vice versa can not be implemented. The issue is related to graph-theoretical properties. It seems that the problem arises from the fact that the theoretical properties component is designed as a component rather than a service (so removing the poper elements outside the component cannot be managed). I have tried making changes and attempting different solutions, but so far, I have been unable to resolve the issue. One suggestion I have received is to remove all highlight elements when adding anomaly badges. This will also remove the highlights. Screen Recording 2024-07-09 at 17 19 38

ugurdogrusoz commented 4 months ago
  1. How about moving one of the overlapping badges to a different location on the node? Middle right or bottom right?
  2. "Pull Requests: Change Line of Code": are we talking about changed lines of code here? If so, let's rename it as "Pull Requests: Changed Lines of Code"
LaraMerdol commented 3 months ago

Subtask 6 fixed: Changed according to the feedback.

Screen Shot 2024-07-15 at 23 38 01

Subtask 5 fixed: Now, if the theoretical property badge and anomaly detection badges are clicked, the anomaly badge will appear in the right corner. Additionally, the anomaly badge size will change to match the issue node size. Screen Recording 2024-07-15 at 23 27 46 If the anomaly badge is clicked, the theoretical properties anomaly badges swap to the right position, and the size is updated to be scaled with the new anomaly size. Screen Recording 2024-07-15 at 23 37 20

ugurdogrusoz commented 3 months ago

This issue is clutter. I am closing this and opening a new one with any remaining problems.