iVis-at-Bilkent / sybvals

SyBValS: Systems Biology Validation Service
MIT License
2 stars 0 forks source link

Clean code and dependencies #18

Closed hasanbalci closed 2 months ago

hasanbalci commented 4 months ago

After major code-related issues are solved, let's clean the code, remove commented parts and console.log statements, remove unnecessary dependencies from package.json etc. so that we leave a decent coding environment for the maintainers.

YusufZiyaOzgul commented 2 months ago

@hasanbalci @ugurdogrusoz cleanup is done.

hasanbalci commented 2 months ago
YusufZiyaOzgul commented 2 months ago
  • Are we using the following files:

    • syblars_error.log file in root folder
    • main.menu.js in src folder
    • stylesheetNewt.js in src folder
    • There are some variables named as "syblars" in public/js/main.menu.js file. Can we change them to "sybvals"?

    • I also see some commented lines especially in src/index.js and public/js/main.menu.js (like here and here)) and multiple consecutive empty lines (like here). Can you please remove them?

    • I also see sbgnml-to-cytoscape as a dependency in package.json. I guess we're not using it, are we?

@hasanbalci I consider it again and remove unnecessary parts mentioned above.