Closed ugurdogrusoz closed 3 months ago
Items to do/improve:
[x] 1. Update the README to reflect usage/API changes
[x] 2. Rearrange the Settings (bring related items closer so they are separated from the rest in the same row) and add the "Show Resolution Alternatives" checkbox (true
by default)
[x] 3. Use class name (e.g. "Omitted Process") as a label for a node when it has no label
[x] 4. Rearrange error list items to be compact:
[x] 5. Improve resolution alternatives GUI:
[x] 6. Make the default resolution alternative selected by default
[x] 7. We now have this unnecessary horizontal scrollbar even on empty image/error list:
[x] 8. Open File... button box is clipped on the left, need to move it a bit to the right to avoid this:
[x] 9. After we resolve errors, we cannot change image format anymore, it gives error in console.
[x] 10. After we validate or resolve a file, if I click on Open File... button, the number of errors are deleted immediately and if we cancel the opening of a new file, we lose the number of errors. Below images are before clicking on Open File... and after we cancel it.
[x] 11. If we resolve errors second time, then the background of Resolution Alternatives appears in dark grey.
[x] 12. Each error should have a distinct color that persists (its first assigned color stays the same until it is resolved).
for 2: separating spaces 1, 2, 3, and 4 in the image below should be equal and these option groups should be spread out as shown in 5 (right aligned as marked)
for 5: here are additional improvements:
@ugurdogrusoz @hasanbalci for item 7, scrollbar is made hidden, for item 9 image format is selected correctly after resolve operation, for item 10 text on error box is not updated before new sbgn file is uploaded, for seperating spaces 65px margin is given for all 1,2,3 and 4. Unnecessary spaces in accordion is removed. I check font famiy of "Resolution Alternatives", it looks same with others, font-family :Lato.
items 1 & 8 are not addressed, the rest seem to be resolved.
Added item 11.
With item 5, we're not using the same arrows as dropdown boxes for consistency
@YusufZiyaOzgul Is it possible for an error to persist its first assigned color until it is resolved?
@YusufZiyaOzgul Is it possible for an error to persist its first assigned color until it is resolved?
Added this as item 12
@ugurdogrusoz @hasanbalci item 8 is fixed by adding margin and item 5 is fixed by using "icon small angle down" class of semantic ui.
Remaining problems with item 5:
Let's give users a chance to make choice about fixes as follows: In the API:
calcFixChoices
to validation to specify whether or not they would like to see a potential list of fixes for each error when applicable. If this parameter is true, then the service should return a list of potential fixes to the user along with other information.choicesForFixes
for resolving errors that contains the choices of the user for the fix of each error (may be 0 means do not fix; 1 means the first - default - choice, etc.). The resolve operation will take these into account and fix the error by the provided choice. In case a previous fix breaks the current fix, we should skip it.In the demo: