Proper handling of internal errors

iVis-at-Bilkent / sybvals

SyBValS: Systems Biology Validation Service

MIT License

2 stars 0 forks source link

Proper handling of internal errors #34

Closed ugurdogrusoz closed 1 month ago

ugurdogrusoz commented 2 months ago

Currently, when an error is encountered, sometimes the server will crash not gracefully handling the problem so, let's rectify these situations. A generic error that pops up saying "Invalid map or unsupported content!" would be good.

Specifically for example:

We do not support submaps in SBGN (mainly due to SBGN stylesheet not supporting them).
File content might be faulty (syntax error for instance),

YusufZiyaOzgul commented 1 month ago

@ugurdogrusoz @hasanbalci now it gives an generic error message, server does not crash.

hasanbalci commented 1 month ago

Looks good to me.

ugurdogrusoz commented 1 month ago

Can we please add a title to the popup (similar to the ABOUT box) using the same style and the title "ERROR"?

YusufZiyaOzgul commented 1 month ago

Can we please add a title to the popup (similar to the ABOUT box) using the same style and the title "ERROR"?

@ugurdogrusoz it is added now.