bootstrap.sh: Some clean up. - Githubissues

iXit / wine-nine-standalone

Build Gallium Nine support on top of an existing WINE installation

GNU Lesser General Public License v2.1

276 stars 23 forks source link

bootstrap.sh: Some clean up. #12

Closed orbea closed 5 years ago

orbea commented 5 years ago

This is some minor cleanup which I noticed when adding support for slackware. This should be just as portable if not more so than before.

Some things to note:

PKG_CONFIG_32 and PKG_CONFIG_64 are set as blank variables instead of unset variables. Its better to not rely on unset variables.
The main loop is refactored to combine two similar conditionals and move them after the loop. After the loop breaks $i will conveniently be the found distro.
Uses printf instead of echo which is suggested in the posix spec, echo is not neccesarily portable with anything beyond plain text in single quotes.

dhewg commented 5 years ago

Thanks, pushed with some minor modifications!